Skip to content

gh-110383: Fix documentation profile cumtime fix #112221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 3 commits into from
Nov 19, 2023
Merged

gh-110383: Fix documentation profile cumtime fix #112221

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82cccb
gh-110383: Fix documentation profile cumtime fix
aptakhin Nov 17, 2023
11fdc19
Returned second space back
aptakhin Nov 19, 2023
a9a85f5
Reworded table reference
aptakhin Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-110383: Fix documentation profile cumtime fix
  • Loading branch information
@aptakhin
aptakhin committed Nov 17, 2023
commit c82cccb9a8b919a52f27637680153d97235382c4
6 changes: 3 additions & 3 deletions Doc/library/profile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ the following::
1 0.000 0.000 0.000 0.000 _compiler.py:598(_code)
1 0.000 0.000 0.000 0.000 _parser.py:435(_parse_sub)

The first line indicates that 214 calls were monitored. Of those calls, 207
The first line indicates that 214 calls were monitored. Of those calls, 207

@hugovk hugovk Nov 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change unrelated whitespace.

Suggested change
The first line indicates that 214 calls were monitored. Of those calls, 207
The first line indicates that 214 calls were monitored. Of those calls, 207

@aptakhin aptakhin Nov 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I also thought it was unrelated, just pretty close to context too. Returned

@hugovk hugovk Nov 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I also prefer one space, but we allow either one or two: https://devguide.python.org/documentation/style-guide/#use-of-whitespace

were :dfn:`primitive`, meaning that the call was not induced via recursion. The
next line: ``Ordered by: cumulative time``, indicates that the text string in the
far right column was used to sort the output. The column headings include:
next line: ``Ordered by: cumulative time`` indicates rows sorting order
for the table below. The column headings include:
Comment thread
aptakhin marked this conversation as resolved.
Outdated

ncalls
for the number of calls.
Expand Down