Add more comments.

serhiy-storchaka · Jul 13, 2023 · Nov 7, 2023 · Nov 7, 2023 · Nov 7, 2023 · Nov 8, 2023
commit 2d132e6fae6a31993359aec74dd4d8ce28e94144
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
@@ -4872,7 +4872,7 @@ PyCArrayType_from_ctype(PyObject *itemtype, Py_ssize_t length)
         Py_DECREF(key);
         return result;
     }
-
+    // not found
     if (!PyType_Check(itemtype)) {
         PyErr_SetString(PyExc_TypeError,
                         "Expected a type object");

diff --git a/Modules/_ctypes/callproc.c b/Modules/_ctypes/callproc.c
@@ -1922,8 +1922,10 @@ create_pointer_type(PyObject *module, PyObject *cls)
     PyObject *key;
 
     if (PyDict_GetItemRef(_ctypes_ptrtype_cache, cls, &result) != 0) {
+        // error or found
         return result;
     }
+    // not found
     if (PyUnicode_CheckExact(cls)) {
         PyObject *name = PyUnicode_FromFormat("LP_%U", cls);
         result = PyObject_CallFunction((PyObject *)Py_TYPE(&PyCPointer_Type),

diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
@@ -1423,9 +1423,11 @@ _elementtree_Element_get_impl(ElementObject *self, PyObject *key,
         PyObject *attrib = Py_NewRef(self->extra->attrib);
         PyObject *value;
         if (PyDict_GetItemRef(attrib, key, &value) != 0) {
+            // error or found
             Py_DECREF(attrib);
             return value;
         }
+        // not found
         Py_DECREF(attrib);
     }
 

diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
@@ -1120,6 +1120,7 @@ local_getattro(localobject *self, PyObject *name)
     /* Optimization: just look in dict ourselves */
     PyObject *value;
     if (PyDict_GetItemRef(ldict, name, &value) != 0) {
+        // error or found
         return value;
     }
 

diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
@@ -522,6 +522,7 @@ PyModule_GetNameObject(PyObject *mod)
     }
     PyObject *name;
     if (PyDict_GetItemRef(dict, &_Py_ID(__name__), &name) <= 0) {
+        // error or not found
         goto error;
     }
     if (!PyUnicode_Check(name)) {
@@ -562,6 +563,7 @@ PyModule_GetFilenameObject(PyObject *mod)
     }
     PyObject *fileobj;
     if (PyDict_GetItemRef(dict, &_Py_ID(__file__), &fileobj) <= 0) {
+        // error or not found
         goto error;
     }
     if (!PyUnicode_Check(fileobj)) {

diff --git a/Objects/object.c b/Objects/object.c
@@ -1489,10 +1489,12 @@ _PyObject_GetMethod(PyObject *obj, PyObject *name, PyObject **method)
     if (dict != NULL) {
         Py_INCREF(dict);
         if (PyDict_GetItemRef(dict, name, method) != 0) {
+            // error or found
             Py_DECREF(dict);
             Py_XDECREF(descr);
             return 0;
         }
+        // not found
         Py_DECREF(dict);
     }
 

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -10247,6 +10247,7 @@ _super_lookup_descr(PyTypeObject *su_type, PyTypeObject *su_obj_type, PyObject *
         assert(dict != NULL && PyDict_Check(dict));
 
         if (PyDict_GetItemRef(dict, name, &res) != 0) {
+            // error or found
             Py_DECREF(mro);
             return res;
         }

diff --git a/Python/import.c b/Python/import.c
@@ -2373,9 +2373,10 @@ get_path_importer(PyThreadState *tstate, PyObject *path_importer_cache,
         return NULL; /* Shouldn't happen */
 
     if (PyDict_GetItemRef(path_importer_cache, p, &importer) != 0) {
+        // error or found
         return importer;
     }
-
+    // not found
     /* set path_importer_cache[p] to None to avoid recursion */
     if (PyDict_SetItem(path_importer_cache, p, Py_None) != 0)
         return NULL;