Skip to content

GH-109369: Exit tier 2 if executor is invalid #111657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 11 commits into from
Nov 9, 2023
Merged

GH-109369: Exit tier 2 if executor is invalid #111657

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8fb3c7d
Exit uop trace if trace is invalid
markshannon Nov 1, 2023
62d5e68
Merge branch 'main' into exit-if-invalid
markshannon Nov 1, 2023
3dc1695
Remove debug code
markshannon Nov 1, 2023
285600c
Merge branch 'main' into exit-if-invalid
markshannon Nov 3, 2023
1630127
Remove most surplus _CHECK_VALIDITY uops
markshannon Nov 3, 2023
1a86439
Add news
markshannon Nov 3, 2023
cccba8c
Merge branch 'main' into exit-if-invalid
markshannon Nov 4, 2023
65b6e36
Make sure IP is up to date when checing validity.
markshannon Nov 4, 2023
f04bf61
Minor fixes
markshannon Nov 4, 2023
d624231
Update Python/optimizer.c
markshannon Nov 8, 2023
ce36706
Merge branch 'main' into exit-if-invalid
markshannon Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Python/optimizer.c 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
  • Loading branch information
@markshannon @iritkatriel
markshannon and iritkatriel authored Nov 8, 2023
commit d6242312fc0762a877af0e51e191d8feb9c4ade9
2 changes: 1 addition & 1 deletion Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ translate_bytecode_to_trace(
} \
reserved = (n); // Keep ADD_TO_TRACE / ADD_TO_STUB honest

// Reserve space for main+stub uops, plus 2 for _SET_IP, _CHECK_VALIDITY and _EXIT_TRACE
// Reserve space for main+stub uops, plus 3 for _SET_IP, _CHECK_VALIDITY and _EXIT_TRACE
#define RESERVE(main, stub) RESERVE_RAW((main) + (stub) + 3, uop_name(opcode))

// Trace stack operations (used by _PUSH_FRAME, _POP_FRAME)
Expand Down