Skip to content

gh-111495: Add tests for PyFloat C API #111624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 13 commits into from
Nov 5, 2023
Merged

gh-111495: Add tests for PyFloat C API #111624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2f2e77f
gh-111495: Add tests for PyFloat C API
skirpichev Nov 1, 2023
1d12623
Add missing coverage tests
skirpichev Nov 2, 2023
3e9c05b
remove redundant tests for PyFloat_FromString()
skirpichev Nov 2, 2023
04718df
Update Lib/test/test_capi/test_float.py
skirpichev Nov 3, 2023
7b9b886
Merge branch 'main' into capi-float-tests
skirpichev Nov 4, 2023
71e9cd0
Address review (partially)
skirpichev Nov 4, 2023
4a00f1d
Use PyArg_Parse() in float_asdouble()
skirpichev Nov 4, 2023
918b56e
Add float_asdouble()
skirpichev Nov 5, 2023
44ff4b2
s/3.14/4.25/g
skirpichev Nov 5, 2023
14c932e
memoryview tests
skirpichev Nov 5, 2023
26f843c
Group logical blocks
skirpichev Nov 5, 2023
54ec7b3
make test module executable
skirpichev Nov 5, 2023
463ec44
Apply suggestions from code review
serhiy-storchaka Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka authored Nov 5, 2023
commit 463ec446a43fabfa359049a8d6ea5d0edad984de
9 changes: 2 additions & 7 deletions Lib/test/test_capi/test_float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@


class CAPIFloatTest(unittest.TestCase):
def assertEqualWithSign(self, actual, expected):
self.assertEqual(actual, expected)
self.assertEqual(math.copysign(1, actual), math.copysign(1, expected))

def test_check(self):
# Test PyFloat_Check()
check = _testcapi.float_check
Expand All @@ -26,7 +22,6 @@ def test_check(self):
self.assertTrue(check(FloatSubclass(4.25)))
self.assertFalse(check(Float()))
self.assertFalse(check(3))
self.assertFalse(check([]))
self.assertFalse(check(object()))

# CRASHES check(NULL)
Expand All @@ -39,7 +34,6 @@ def test_checkexact(self):
self.assertFalse(checkexact(FloatSubclass(4.25)))
self.assertFalse(checkexact(Float()))
self.assertFalse(checkexact(3))
self.assertFalse(checkexact([]))
self.assertFalse(checkexact(object()))

# CRASHES checkexact(NULL)
Expand Down Expand Up @@ -78,8 +72,9 @@ def __float__(self):
raise RuntimeError

self.assertEqual(asdouble(4.25), 4.25)
self.assertEqual(asdouble(-1), -1.0)
self.assertEqual(asdouble(-1.0), -1.0)
self.assertEqual(asdouble(42), 42.0)
self.assertEqual(asdouble(-1), -1.0)
Comment thread
skirpichev marked this conversation as resolved.
self.assertEqual(asdouble(2**1000), float(2**1000))

self.assertEqual(asdouble(FloatSubclass(4.25)), 4.25)
Expand Down
2 changes: 1 addition & 1 deletion Modules/_testcapi/float.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ float_asdouble(PyObject *Py_UNUSED(module), PyObject *obj)
return PyFloat_FromDouble(d);
}

static PyObject*
static PyObject *
float_getinfo(PyObject *Py_UNUSED(module), PyObject *Py_UNUSED(arg))
{
return PyFloat_GetInfo();
Expand Down