Skip to content

gh-111089: Add cache to PyUnicode_AsUTF8() for embedded NUL #111587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 9 commits into from
Closed

gh-111089: Add cache to PyUnicode_AsUTF8() for embedded NUL #111587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8004312
gh-111089: Add cache to PyUnicode_AsUTF8() for embedded NUL
vstinner Nov 1, 2023
a7e93c9
fixup! gh-111089: Add cache to PyUnicode_AsUTF8() for embedded NUL
vstinner Nov 1, 2023
4ccd7d9
Fix _PyUnicode_CheckConsistency() in release mode
vstinner Nov 1, 2023
3c4844f
Add constant
vstinner Nov 1, 2023
e224751
unicode_resize() clears embed_null cache
vstinner Nov 1, 2023
65c6671
Add What's New entry
vstinner Nov 1, 2023
30bb725
Make the fast path faster.
vstinner Nov 1, 2023
07975be
Revert test unicode_fromstring() change
vstinner Nov 1, 2023
e3c6fa5
Set embed_null in more cases on new strings
vstinner Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add What's New entry
  • Loading branch information
@vstinner
vstinner committed Nov 1, 2023
commit 65c667132ddff29e5d253e43412d840afbdc49c3
9 changes: 8 additions & 1 deletion Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,6 +1120,13 @@ New Features
* Add :c:func:`PyUnicode_AsUTF8` function to the limited C API.
(Contributed by Victor Stinner in :gh:`111089`.)

* Add ``PyASCIIObject.state.embed_null`` member to Python :class:`str` objects.
It is used as a cache by :c:func:`PyUnicode_AsUTF8` to only check once if a
string contains a null character. Strings created by
:c:func:`PyUnicode_FromString` initializes *embed_null* to 0 since the string
cannot contain a null character.
(Contributed by Victor Stinner in :gh:`111089`.)


Porting to Python 3.13
----------------------
Expand Down Expand Up @@ -1192,7 +1199,7 @@ Porting to Python 3.13

* The :c:func:`PyUnicode_AsUTF8` function now raises an exception if the string
contains embedded null characters. To accept embedded null characters and
truncate on purpose at the first null byte,
truncate on purpose at the first null character,
``PyUnicode_AsUTF8AndSize(unicode, NULL)`` can be used instead.
(Contributed by Victor Stinner in :gh:`111089`.)

Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/C API/2023-11-01-03-18-21.gh-issue-111089.GxXlz0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Add ``PyASCIIObject.state.embed_null`` member to Python str objects. It is
used as a cache by :c:func:`PyUnicode_AsUTF8` to only check once if a string
contains a null character. Strings created by :c:func:`PyUnicode_FromString`
initializes *embed_null* since the string cannot contain a null character.
initializes *embed_null* to 0 since the string cannot contain a null character.
Patch by Victor Stinner.