Skip to content

gh-108082: Use PyErr_FormatUnraisable() #111580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 9 commits into from
Nov 2, 2023
Merged

gh-108082: Use PyErr_FormatUnraisable() #111580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e126cd5
gh-108082: Use PyErr_FormatUnraisable()
serhiy-storchaka Oct 19, 2023
7e2a600
Apply suggestions from code review
serhiy-storchaka Nov 1, 2023
3a60137
Merge branch 'main' into use-PyErr_FormatUnraisable
serhiy-storchaka Nov 1, 2023
5f3b94a
Fixes.
serhiy-storchaka Nov 1, 2023
4f3292b
Fix test_cmd_line.
serhiy-storchaka Nov 1, 2023
6445a4a
Fix tests on Windows.
serhiy-storchaka Nov 1, 2023
331bcaf
Update Objects/typeobject.c
serhiy-storchaka Nov 2, 2023
c671f07
Merge branch 'main' into use-PyErr_FormatUnraisable
serhiy-storchaka Nov 2, 2023
4c15b7e
Update tests.
serhiy-storchaka Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@serhiy-storchaka @vstinner
serhiy-storchaka and vstinner authored Nov 1, 2023
commit 7e2a600c9aa43678f8397adad554671525a77b94
4 changes: 2 additions & 2 deletions Modules/getpath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ _PyConfig_InitPathConfig(PyConfig *config, int compute_path_config)
) {
Py_DECREF(co);
Py_DECREF(dict);
PyErr_FormatUnraisable("Exception ignored in evaluating initial values");
PyErr_FormatUnraisable("Exception ignored in preparing getpath");
return PyStatus_Error("error evaluating initial values");
}

Expand All @@ -919,7 +919,7 @@ _PyConfig_InitPathConfig(PyConfig *config, int compute_path_config)

if (!r) {
Py_DECREF(dict);
PyErr_FormatUnraisable("Exception ignored in evaluating path");
PyErr_FormatUnraisable("Exception ignored in running getpath");
return PyStatus_Error("error evaluating path");
}
Py_DECREF(r);
Expand Down
2 changes: 1 addition & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ _PyImport_ClearModulesByIndex(PyInterpreterState *interp)
if (PyList_SetSlice(MODULES_BY_INDEX(interp),
0, PyList_GET_SIZE(MODULES_BY_INDEX(interp)),
NULL)) {
PyErr_FormatUnraisable("Exception ignored on clearing interpreters module-list");
PyErr_FormatUnraisable("Exception ignored on clearing interpreters module list");
}
}

Expand Down
2 changes: 1 addition & 1 deletion Python/perf_trampoline.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ new_code_arena(void)
if (new_arena == NULL) {
PyErr_NoMemory();
munmap(memory, mem_size);
PyErr_FormatUnraisable("Failed to allocate new code arena struct");
PyErr_FormatUnraisable("Failed to allocate new code arena struct for perf trampoline");
return -1;
}

Expand Down