add test for setitem

Signed-off-by: kalyanr <kalyan.ben10@live.com>
vstinner · Nov 8, 2023 · Oct 31, 2023 · Oct 31, 2023 · Oct 31, 2023 · Oct 31, 2023
commit 3166ba44bb6a176be161ce9a2434602982c337d7
diff --git a/Lib/test/test_capi/test_list.py b/Lib/test/test_capi/test_list.py
@@ -10,6 +10,7 @@
 class ListSubclass(list):
     ...
 
+
 class CAPITest(unittest.TestCase):
     def test_check(self):
         # Test PyList_Check()
@@ -69,3 +70,16 @@ def test_list_get_item(self):
 
         # CRASHES for out of index: get_item(lst, 3)
         # CRASHES get_item(21, 2)
+
+
+    def test_list_setitem(self):
+        setitem = _testcapi.list_setitem
+        lst = [1, 2, 3]
+        setitem(lst, 1, 10)
+        self.assertEqual(lst[1], 10)
+        self.assertRaises(IndexError, setitem, [1], -1, 5)
+        self.assertRaises(TypeError, setitem, lst, 1.5, 10)
+        self.assertRaises(TypeError, setitem, 23, 'a', 5)
+        self.assertRaises(SystemError, setitem, {}, 0, 5)
+
+        # CRASHES setitem(NULL, 'a', 5)
diff --git a/Modules/_testcapi/list.c b/Modules/_testcapi/list.c
@@ -52,6 +52,20 @@ list_get_item(PyObject *Py_UNUSED(module), PyObject *args)
     return PyList_GET_ITEM(obj, i);
 }
 
+static PyObject *
+list_setitem(PyObject *Py_UNUSED(module), PyObject *args)
+{
+    PyObject *obj, *value;
+    Py_ssize_t i;
+    if ( !PyArg_ParseTuple(args, "OnO", &obj, &i, &value)){
+        return NULL;
+    }
+    NULLABLE(obj);
+    NULLABLE(value);
+    RETURN_INT(PyList_SetItem(obj, i, value));
+
+}
+
 
 static PyMethodDef test_methods[] = {
     {"list_check", list_check, METH_O},
@@ -60,7 +74,7 @@ static PyMethodDef test_methods[] = {
     {"list_size", list_size, METH_O},
     {"list_getitem", list_getitem, METH_VARARGS},
     {"list_get_item", list_get_item, METH_VARARGS},
-    // {"list_setitem", list_setitem, METH_VARARGS},
+    {"list_setitem", list_setitem, METH_VARARGS},
     // {"list_insert"},
     // {"list_append"},
     // {"list_get_slice"},