Make the new C API not public.

serhiy-storchaka · May 28, 2025 · Sep 20, 2023 · Oct 18, 2023 · Oct 18, 2023 · Oct 19, 2023
commit 516829e8e5059bc2d6cb5dfecd6b5bc608910c75
diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst
@@ -993,12 +993,6 @@ New Features
 
   (Contributed by Serhiy Storchaka in :gh:`108511`.)
 
-* Add functions :c:func:`PySys_GetAttr`, :c:func:`PySys_GetAttrString`,
-  :c:func:`PySys_GetOptionalAttr` and :c:func:`PySys_GetOptionalAttrString`.
-  They all are variants of :c:func:`PySys_GetObject` which return a new
-  :term:`strong reference` and can set an exception on failure.
-  (Contributed by Serhiy Storchaka in :gh:`108512`.)
-
 * If Python is built in :ref:`debug mode <debug-build>` or :option:`with
   assertions <--with-assertions>`, :c:func:`PyTuple_SET_ITEM` and
   :c:func:`PyList_SET_ITEM` now check the index argument with an assertion.

diff --git a/Include/cpython/sysmodule.h b/Include/cpython/sysmodule.h
@@ -10,6 +10,11 @@ PyAPI_FUNC(int) PySys_Audit(
     ...);
 PyAPI_FUNC(int) PySys_AddAuditHook(Py_AuditHookFunction, void*);
 
+PyAPI_FUNC(PyObject *) PySys_GetAttr(PyObject *);
+PyAPI_FUNC(PyObject *) PySys_GetAttrString(const char *);
+PyAPI_FUNC(int) PySys_GetOptionalAttr(PyObject *, PyObject **);
+PyAPI_FUNC(int) PySys_GetOptionalAttrString(const char *, PyObject **);
+
 typedef struct {
     FILE* perf_map;
     PyThread_type_lock map_lock;

@@ -8,12 +8,6 @@ extern "C" {
 #endif
 
 PyAPI_FUNC(PyObject *) PySys_GetObject(const char *);
-#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x030D0000
-PyAPI_FUNC(PyObject *) PySys_GetAttr(PyObject *);
-PyAPI_FUNC(PyObject *) PySys_GetAttrString(const char *);
-PyAPI_FUNC(int) PySys_GetOptionalAttr(PyObject *, PyObject **);
-PyAPI_FUNC(int) PySys_GetOptionalAttrString(const char *, PyObject **);
-#endif
 PyAPI_FUNC(int) PySys_SetObject(const char *, PyObject *);
 
 PyAPI_FUNC(void) PySys_WriteStdout(const char *format, ...)

diff --git a/Misc/NEWS.d/next/C API/2023-10-18-14-36-35.gh-issue-108512.fMZLfr.rst b/Misc/NEWS.d/next/C API/2023-10-18-14-36-35.gh-issue-108512.fMZLfr.rst
@@ -1,2 +1,2 @@
-Add functions :c:func:`PySys_GetAttr`, :c:func:`PySys_GetAttrString`,
+Add private functions :c:func:`PySys_GetAttr`, :c:func:`PySys_GetAttrString`,
 :c:func:`PySys_GetOptionalAttr` and :c:func:`PySys_GetOptionalAttrString`.