Skip to content

gh-84570: Implement Waiting in SendChannel.send() #110565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 7 commits into from
Oct 10, 2023
Merged

gh-84570: Implement Waiting in SendChannel.send() #110565

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c617361
Implement waiting for _channels.send().
ericsnowcurrently Sep 18, 2023
1701ca0
Release the GIL while waiting for the send lock.
ericsnowcurrently Oct 9, 2023
b5dbf81
Fix tests.
ericsnowcurrently Oct 9, 2023
d3aefb8
Update the doc strings.
ericsnowcurrently Oct 9, 2023
5b6574e
Wait when receiving from a thread.
ericsnowcurrently Oct 9, 2023
fbd7945
wait -> blocking
ericsnowcurrently Oct 10, 2023
b85a681
Fix the tests.
ericsnowcurrently Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wait when receiving from a thread.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 9, 2023
commit 5b6574e9fcb25d91d30dd91cecf361de0edf462a
19 changes: 11 additions & 8 deletions Lib/test/test__xxinterpchannels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@
##################################
# helpers

def recv_wait(cid):
while True:
try:
return channels.recv({cid})
break
except channels.ChannelEmptyError:
time.sleep(0.1)

#@contextmanager
#def run_threaded(id, source, **shared):
# def run():
Expand Down Expand Up @@ -595,18 +603,13 @@ def test_send_recv_different_threads(self):
cid = channels.create()

def f():
while True:
try:
obj = channels.recv(cid)
break
except channels.ChannelEmptyError:
time.sleep(0.1)
obj = recv_wait(cid)
channels.send(cid, obj)
t = threading.Thread(target=f)
t.start()

channels.send(cid, b'spam')
obj = channels.recv(cid)
obj = recv_wait(cid)
t.join()

self.assertEqual(obj, b'spam')
Expand Down Expand Up @@ -634,7 +637,7 @@ def f():
t.start()

channels.send(cid, b'spam')
obj = channels.recv(cid)
obj = recv_wait(cid)
t.join()

self.assertEqual(obj, b'eggs')
Expand Down