Skip to content

bpo-22577: in pdb, prevent changes to locals from being lost after a jump #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scotchka wants to merge 6 commits into from
Closed

bpo-22577: in pdb, prevent changes to locals from being lost after a jump #11041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a205b3
bpo-22577: in pdb, prevent changes to locals from being lost after a …
scotchka Dec 9, 2018
45103df
NEWS item added
scotchka Dec 9, 2018
ce391fc
regression test to ensure local variable change persists
scotchka Dec 9, 2018
c6f365b
undo change that caused regression error
scotchka Jan 10, 2019
9307a4e
project curframe_locals from jump by saving and restoring
scotchka Jan 10, 2019
e7a668f
move save/restore of locals to print_stack_entry to eliminate side ef…
scotchka Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-22577: in pdb, prevent changes to locals from being lost after a … 
…jump
  • Loading branch information
@scotchka
scotchka committed Dec 9, 2018
commit 2a205b3f68d191fd41e876a32c9a8cf9e7998b2f
2 changes: 1 addition & 1 deletion Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def setup(self, f, tb):
# The f_locals dictionary is updated from the actual frame
# locals whenever the .f_locals accessor is called, so we
# cache it here to ensure that modifications are not overwritten.
self.curframe_locals = self.curframe.f_locals
self.curframe_locals = dict(self.curframe.f_locals)
return self.execRcLines()

# Can be executed earlier than 'setup' if desired
Expand Down
24 changes: 24 additions & 0 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,30 @@ def test_pdb_issue_20766():
pdb 2: <built-in function default_int_handler>
"""

def test_issue22577():
"""Test that local variable change not lost after jump.

>>> def test_function(x):
... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
... lineno = 3
... lineno = 4

>>> with PdbTestInput(['x = 123',
... 'jump 4',
... 'x',
... 'continue']):
... test_function(1)
> <doctest test.test_pdb.test_issue22577[0]>(3)test_function()
-> lineno = 3
(Pdb) x = 123
(Pdb) jump 4
> <doctest test.test_pdb.test_issue22577[0]>(4)test_function()
-> lineno = 4
(Pdb) x
123
(Pdb) continue
"""


class PdbTestCase(unittest.TestCase):
def tearDown(self):
Expand Down