Skip to content

GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section #109751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 9 commits into from
Sep 25, 2023
Merged

GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section #109751

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02824ae
Move C-API deprecations to the C-API section
AA-Turner Sep 22, 2023
f9a6a95
Copy the 3.13 "Pending Removal in Future Versions" list
AA-Turner Sep 22, 2023
5d87553
Note that the global config variables will be removed in 3.14
AA-Turner Sep 22, 2023
1653e42
Copy the 3.13 "Pending Removal in Python 3.15" list
AA-Turner Sep 22, 2023
ac8849c
Note pending removal of PyErr_Display
AA-Turner Sep 22, 2023
4502df2
Suggest alternative for ``_PyErr_ChainExceptions``
AA-Turner Sep 22, 2023
a9241e2
Fix rebase error (restore position; use nicer markup)
AA-Turner Sep 22, 2023
7312d08
Suggest more replacement functions
AA-Turner Sep 25, 2023
2420937
syntax
AA-Turner Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suggest more replacement functions 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
@AA-Turner @serhiy-storchaka
AA-Turner and serhiy-storchaka authored Sep 25, 2023
commit 7312d08ebeb2b0d9af3d45925680dfe26f08f2e9
12 changes: 6 additions & 6 deletions Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,12 +2180,12 @@ although there is currently no date scheduled for their removal.
* :c:func:`PyErr_NormalizeException`: use :c:func:`PyErr_GetRaisedException`
* :c:func:`PyErr_Restore`: use :c:func:`PyErr_SetRaisedException`
* :c:func:`PyModule_GetFilename`: use :c:func:`PyModule_GetFilenameObject`
* :c:func:`PyOS_AfterFork`: use :c:func:`PyOS_AfterFork_Child()`
* :c:func:`PySlice_GetIndicesEx`
* :c:func:`!PyUnicode_AsDecodedObject`
* :c:func:`!PyUnicode_AsDecodedUnicode`
* :c:func:`!PyUnicode_AsEncodedObject`
* :c:func:`!PyUnicode_AsEncodedUnicode`
* :c:func:`PyOS_AfterFork`: use :c:func:`PyOS_AfterFork_Child`
* :c:func:`PySlice_GetIndicesEx`: use :c:func:`PySlice_Unpack` and :c:func:`PySlice_AdjustIndices`
* :c:func:`!PyUnicode_AsDecodedObject`: use c:func:`PyCodec_Decode`
* :c:func:`!PyUnicode_AsDecodedUnicode`: use c:func:`PyCodec_Decode`
* :c:func:`!PyUnicode_AsEncodedObject`: use c:func:`PyCodec_Encode`
* :c:func:`!PyUnicode_AsEncodedUnicode`: use c:func:`PyCodec_Encode`
Comment thread
AA-Turner marked this conversation as resolved.
Outdated
* :c:func:`PyUnicode_READY`: unneeded since Python 3.12
* :c:func:`!PyErr_Display`: use :c:func:`PyErr_DisplayException`
* :c:func:`!_PyErr_ChainExceptions`: use ``_PyErr_ChainExceptions1``

@serhiy-storchaka serhiy-storchaka Sep 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. It is an internal convenient function, and it can be removed or changed in incompatible way without warning.

@AA-Turner AA-Turner Sep 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're recommending a private replacement to a private function here, so I think it's fine. This isn't saying that readers should use the functions, just what the replacements for the deprecated versions are.

Expand Down