Skip to content

gh-78469: Declare missing sethostname for Solaris 10 #109447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 8 commits into from
Oct 9, 2023
Merged

gh-78469: Declare missing sethostname for Solaris 10 #109447

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e71d8fb
Add OS version specific macro for Solaris
kulikjak Sep 15, 2023
5593f21
declare sethostname in socketmodule.c for Solaris 10
kulikjak Sep 15, 2023
bc5523e
rename SUNOS_VERSION to Py_SUNOS_VERSION (PEP 7 naming conventions)
kulikjak Oct 5, 2023
3a96e29
Update configure.ac
kulikjak Oct 6, 2023
691441c
Update configure
kulikjak Oct 6, 2023
f8f49e4
Run make regen-configure
vstinner Oct 6, 2023
5970802
Update Modules/socketmodule.c
vstinner Oct 6, 2023
9cb0a31
Merge branch 'main' into Solaris10-sethostname
erlend-aasland Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update configure.ac 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@kulikjak @vstinner
kulikjak and vstinner authored Oct 6, 2023
commit 3a96e294ca75786d594b0190b9d03d443b4e91b5
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ then
if test "$ac_sys_system" = "SunOS"; then
# For Solaris, there isn't an OS version specific macro defined
# in most compilers, so we define one here.
SUNOS_VERSION=`echo $ac_sys_release | tr -d '.'`
SUNOS_VERSION=`echo $ac_sys_release | sed -e 's!\.\([0-9]\)$!.0\1!g' | tr -d '.'`
AC_DEFINE_UNQUOTED([Py_SUNOS_VERSION], [$SUNOS_VERSION],
[The version of SunOS/Solaris as reported by `uname -r' without the dot.])

@vstinner vstinner Sep 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you distinguish Solaris 5.10 and Solaris 51.0?

Maybe multiply the major version by 100 or 1000? or use a shift of 8 bits? The usage would be:

major = VERSION >> 8
minor = VERSION & 255

The disavantage is the need to write versions in hexadecimal :-(

@vstinner vstinner Sep 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland: Should we prefix new pyconfig.h constants by Py_ ? see: capi-workgroup/problems#46

@erlend-aasland erlend-aasland Sep 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should follow the PEP-7 recommendations: https://peps.python.org/pep-0007/#naming-conventions

@kulikjak kulikjak Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you distinguish Solaris 5.10 and Solaris 51.0?

I see what you mean, but that's not happening. The leading 5 was dropped from the name 25 years ago and while e.g. uname and compilation targets still use it, nobody today calls it Solaris/SunOS 5.10; only Solaris 10. If we ever release Solaris 51, uname -r should report it as 5.51.

That said, I am not strongly against changing it if you still prefer your suggestion.

I think we should follow the PEP-7 recommendations: https://peps.python.org/pep-0007/#naming-conventions

Thanks, I missed that. It's fixed now.

fi
Expand Down