Skip to content

gh-109125: Run mypy on Tools/wasm #109126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 5 commits into from
Sep 19, 2023
Merged

gh-109125: Run mypy on Tools/wasm #109126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00ecd77
gh-109125: Run mypy on `Tools/wasm`
sobolevn Sep 8, 2023
fe0dad3
Fix actions
sobolevn Sep 8, 2023
a1725b4
Address review
sobolevn Sep 11, 2023
69986ae
Merge branch 'main' into issue-109125
sobolevn Sep 16, 2023
35fa459
ABCDEF sorting
sobolevn Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Sep 11, 2023
commit a1725b4f30fa228b0c359bdc32fa215b39f8056a
5 changes: 2 additions & 3 deletions Tools/wasm/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ python_version = 3.8
strict = True

@brettcannon brettcannon Sep 8, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this mean all code in this directory must be fully typed?

@sobolevn sobolevn Sep 9, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore any code that is not typed:

  1. Via adding global disallow_incomplete_defs = false
  2. Via per-file ignores
  3. Via inline # type: ignore

For now, yes, all code must be typed. Do you want to add disallow_incomplete_defs = false?

@brettcannon brettcannon Sep 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add disallow_incomplete_defs = false?

Yes please.

enable_error_code = truthy-bool,ignore-without-code

# except for a few settings that can't yet be enabled:
warn_return_any = False
warn_unreachable = False
# except for incomplete defs, which are useful for module authors:
disallow_incomplete_defs = False
3 changes: 2 additions & 1 deletion Tools/wasm/wasm_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ def get_builddir(args: argparse.Namespace) -> pathlib.Path:

def get_sysconfigdata(args: argparse.Namespace) -> pathlib.Path:
"""Get path to sysconfigdata relative to build root"""
data_name = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
assert isinstance(args.builddir, pathlib.Path)
data_name: str = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
if not data_name.startswith(SYSCONFIG_NAMES):
raise ValueError(
f"Invalid sysconfig data name '{data_name}'.", SYSCONFIG_NAMES
Expand Down