Repository navigation
gh-108927: Fix removing testing modules from sys.modules - #108952
Merged
serhiy-storchaka merged 20 commits intoDec 4, 2023
Merged
serhiy-storchaka merged 20 commits into
serhiy-storchaka merged 20 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that does this properly never worked since Python 3.0.
And removing only the tested module breaks import machinery if it has submodules used in other tests.