Skip to content

test_unittest failure triggered by test_import + test_importlib #108927

Closed
Closed
test_unittest failure triggered by test_import + test_importlib#108927
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@Yhg1s
Yhg1s
opened on Sep 5, 2023

Bug report

Bug description:

test_unittest fails if (and only if) test_import and test_importlib are run (in the same process) before it:

./python -m test test_import test_importlib test_unittest
0:00:00 load avg: 3.83 Run tests sequentially
0:00:00 load avg: 3.83 [1/3] test_import
0:00:02 load avg: 3.52 [2/3] test_importlib
0:00:06 load avg: 3.24 [3/3] test_unittest
test test_unittest failed -- Traceback (most recent call last):
  File "/home/thomas/python/python/cpython/Lib/test/test_unittest/test_discovery.py", line 840, in test_discovery_failed_discovery
    with test.test_importlib.util.uncache('package'):
         ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'test.test_importlib' has no attribute 'util'

test_unittest failed (1 error)

CPython versions tested on:

3.12, CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. Yhg1s
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 5, 2023
  2. sobolevn
    added a commit that references this issue on Sep 5, 2023

    pythongh-108927: Fix test_import + test_importlib + test_unittest pro…

    5ceeafe

  3. serhiy-storchaka commented on Sep 5, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 5, 2023
    Member
    1. test_import imports test.test_importlib.util. 'test.test_importlib' and 'test.test_importlib.util' are now in sys.modules.
    2. Somebody removes 'test.test_importlib' from sys.modules but leaves 'test.test_importlib.util'.
    3. libregrtest imports test.test_importlib. test now has attribute test_importlib.
    4. test_unittest.test_discovery requests to import test.test_importlib.util at import time, and since it is found in sys.modules, it simply sets module global test.
    5. It now tries to access test.test_importlib.util. Global test has attribute test_importlib, but test.test_importlib has no attribute util.

  4. serhiy-storchaka commented on Sep 5, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 5, 2023
    Member

    2. Somebody removes 'test.test_importlib' from sys.modules but leaves 'test.test_importlib.util'.

    libregrtest does this for every tested module. Now this sequence is clear:

    1. test_import imports test.test_importlib.util.
    2. libregrtest messes with import machinery by removing and re-importing test_importlib.
    3. test_unittest imports and use test.test_importlib.util.

    You can use other tests which import test.test_importlib.util, just add test_importlib between two of such tests.

  5. serhiy-storchaka
    added 2 commits that reference this issue on Sep 5, 2023

    pythongh-108927: Do not remove tested modules from sys.modules

    4f7617c

    pythongh-108927: Do not remove tested modules from sys.modules

    339f260

  6. serhiy-storchaka commented on Sep 5, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 5, 2023
    Member

    test_compileall yet one test which can fail after test_importlib.

    Details 
    $ ./python -m test -v test_import test_importlib test_compileall
...
---------------------------------------------------------
Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/test/test_py_compile.py", line 22, in wrapper
    return fxn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/serhiy/py/cpython/Lib/test/test_compileall.py", line 331, in test_ddir_multiple_workers
    return self._test_ddir_only(ddir="<a prefix>", parallel=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/serhiy/py/cpython/Lib/test/test_compileall.py", line 320, in _test_ddir_only
    mod_code_obj = test.test_importlib.util.get_code_from_pyc(modcode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'test.test_importlib' has no attribute 'util'

======================================================================
ERROR: test_ddir_only_one_worker (test.test_compileall.CompileallTestsWithoutSourceEpoch.test_ddir_only_one_worker)
Recursive compile_dir ddir= contains package paths; bpo39769.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/test/test_py_compile.py", line 22, in wrapper
    return fxn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/serhiy/py/cpython/Lib/test/test_compileall.py", line 326, in test_ddir_only_one_worker
    return self._test_ddir_only(ddir="<a prefix>", parallel=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/serhiy/py/cpython/Lib/test/test_compileall.py", line 320, in _test_ddir_only
    mod_code_obj = test.test_importlib.util.get_code_from_pyc(modcode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'test.test_importlib' has no attribute 'util'

----------------------------------------------------------------------

    #108952 fixes all such cases.

  7. Yhg1s
    added a commit that references this issue on Sep 5, 2023

    gh-108927: Fix test_import + test_importlib + test_unittest problem (#…

    3f89b25
  8. miss-islington
    added a commit that references this issue on Sep 5, 2023

    pythongh-108927: Fix test_import + test_importlib + test_unittest pro…

    ec43ba0
  9. Yhg1s
    added a commit that references this issue on Sep 5, 2023

    [3.12] gh-108927: Fix test_import + test_importlib + test_unittest pr…

    460043b

  10. lordmauve commented on Oct 4, 2023

    @lordmauve
    lordmauve
    on Oct 4, 2023
    Contributor

    I am also seeing this in the 3.11.6 release and can confirm that #108929 fixes it.

  11. lordmauve commented on Oct 4, 2023

    @lordmauve
    lordmauve
    on Oct 4, 2023
    Contributor

    Actually when I run just ./python -m test test_import test_importlib test_unittest I see this in 3.11.5 and 3.11.4 as well. But 3.11.4's test suite is succeeding on our CI. 3.11.6 is not.

  12. miss-islington
    added a commit that references this issue on Oct 4, 2023

    pythongh-108927: Fix test_import + test_importlib + test_unittest pro…

    727e134
  13. vstinner
    added a commit that references this issue on Oct 4, 2023

    [3.11] gh-108927: Fix test_import + test_importlib + test_unittest pr…

    497c8c4
  14. iritkatriel
    added
    testsTests in the Lib/test dir
    on Nov 26, 2023

  15. 2 remaining items

  16. miss-islington
    added a commit that references this issue on Dec 4, 2023

    pythongh-108927: Fix removing testing modules from sys.modules (pytho…

    07a369c
  17. serhiy-storchaka
    added 2 commits that reference this issue on Dec 4, 2023

    [3.11] gh-108927: Fix removing testing modules from sys.modules (GH-1…

    8dbda1c

    [3.12] gh-108927: Fix removing testing modules from sys.modules (GH-1…

    8d21242
  18. serhiy-storchaka
    closed this as completedon Dec 4, 2023

  19. vstinner commented on Dec 4, 2023

    @vstinner
    vstinner
    on Dec 4, 2023
    Member

    @serhiy-storchaka serhiy-storchaka closed this as completed Dec 4, 2023

    Nice!

  20. serhiy-storchaka
    added 6 commits that reference this issue on Dec 5, 2023

    pythongh-108927: Include new dir test/regrtestdata in the installation

    6a3ef06

    gh-108927: Include new dir test/regrtestdata in the installation (GH-…

    f8c0198

    [3.11] pythongh-108927: Include new dir test/regrtestdata in the inst…

    669d55a

    [3.12] pythongh-108927: Include new dir test/regrtestdata in the inst…

    89ec85e

    [3.11] gh-108927: Include new dir test/regrtestdata in the installati…

    f92c8bf

    [3.12] gh-108927: Include new dir test/regrtestdata in the installati…

    cf16aaa
  21. aisk
    added 2 commits that reference this issue on Feb 11, 2024

    pythongh-108927: Fix removing testing modules from sys.modules (pytho…

    a096f48

    pythongh-108927: Include new dir test/regrtestdata in the installation (

    7c43b81
  22. Glyphack
    added 2 commits that reference this issue on Sep 2, 2024

    pythongh-108927: Fix removing testing modules from sys.modules (pytho…

    6db4be2

    pythongh-108927: Include new dir test/regrtestdata in the installation (

    35d3c68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions