Skip to content

gh-107457: update dis documentation with changes in 3.12 #108900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 9 commits into from
Oct 17, 2023
Merged

gh-107457: update dis documentation with changes in 3.12 #108900

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34250f3
doc: describe how CACHE opcodes are taken into account in jumps
MatthieuDartiailh Sep 4, 2023
e7d9021
doc: document MIN_INSTRUMENTED_OPCODE in dis
MatthieuDartiailh Sep 4, 2023
0586fec
doc: document END_SEND and fix SEND documentation
MatthieuDartiailh Sep 4, 2023
7617456
Doc: clarify CALL_INSTRINSIC_2 stack effect
MatthieuDartiailh Sep 5, 2023
6ad38e3
doc: clarify the stack manipulation of LOAD_SUPER_ATTR
MatthieuDartiailh Sep 5, 2023
3644200
Apply suggestions from code review
MatthieuDartiailh Sep 25, 2023
0a1dee2
Update dis.rst
MatthieuDartiailh Sep 28, 2023
5a93f49
docs: address review comments
MatthieuDartiailh Oct 17, 2023
4291f95
Merge branch 'main' into dis-docs
iritkatriel Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doc: clarify CALL_INSTRINSIC_2 stack effect
  • Loading branch information
@MatthieuDartiailh
MatthieuDartiailh committed Sep 5, 2023
commit 761745675ab7744da353605455bffc5cd606e567
10 changes: 7 additions & 3 deletions Doc/library/dis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,9 +1695,13 @@ iterations of the loop.

.. opcode:: CALL_INTRINSIC_2

Calls an intrinsic function with two arguments. Passes ``STACK[-2]``, ``STACK[-1]`` as the
arguments and sets ``STACK[-1]`` to the result. Used to implement functionality that is
necessary but not performance critical.
Calls an intrinsic function with two arguments. Used to implement functionality
that is necessary but not performance critical::

@iritkatriel iritkatriel Oct 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
that is necessary but not performance critical::
that is not performance critical::

@iritkatriel iritkatriel Oct 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you copied this from the 1-arg opcode. But I think it's redundant in both cases.

@MatthieuDartiailh MatthieuDartiailh Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it


arg2 = STACK.pop()
arg1 = STACK.pop()
result = intrinsic2(arg1, arg2)
STACK.push(result)

The operand determines which intrinsic function is called:

Expand Down