Skip to content

GH-46145: make PyStructSequence compatible with namedtuple #108648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FFY00 wants to merge 21 commits into
base: main
Choose a base branch
from
Open

GH-46145: make PyStructSequence compatible with namedtuple #108648

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
668b9e5
add _fields to PyStructSequence
FFY00 Aug 29, 2023
6ed9a86
add _asdict to PyStructSequence
FFY00 Aug 29, 2023
995a2d9
add news
FFY00 Aug 29, 2023
c7cf78b
add _field_defaults to PyStructSequence
FFY00 Aug 29, 2023
76c0581
(from review) use Py_DECREF instead of Py_XDECREF
FFY00 Aug 29, 2023
5c3e4a5
add tests
FFY00 Aug 29, 2023
48b5c2a
use Py_DECREF instead of Py_XDECREF for defaults in initialize_struct…
FFY00 Aug 29, 2023
173546c
don't support namedtuple helpers when unnamed fields are present
FFY00 Aug 30, 2023
1a4d1f3
Merge branch 'main' into gh-108647
FFY00 Nov 17, 2024
c99456f
Fix linting
FFY00 Nov 17, 2024
8881c96
Fix inconsistent style
FFY00 Nov 17, 2024
0482b08
Fix comment typo
FFY00 Nov 17, 2024
df1bd45
Join code that the comment is referring to
FFY00 Nov 17, 2024
7ec1eb6
Simplify error description
FFY00 Nov 17, 2024
d658233
Put _asdict after dunder methods in structseq_methods
FFY00 Nov 17, 2024
81a07f2
Fix comment typo
FFY00 Nov 17, 2024
de300a6
Fix news doc references
FFY00 Nov 17, 2024
c11f544
Sync structseq_asdict error message
FFY00 Nov 17, 2024
00ae6a8
Add extra checks to _asdict
FFY00 Nov 17, 2024
7fc1885
Add _replace as an alias to __replace__
FFY00 Nov 17, 2024
684d2b2
Add structseq_make
FFY00 Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix inconsistent style 
Signed-off-by: Filipe Laíns <lains@riseup.net>
  • Loading branch information
@FFY00
FFY00 committed Nov 17, 2024
commit 8881c96dcde81fa1d205ff223e95cc6f46f19204
3 changes: 2 additions & 1 deletion Objects/structseq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,8 +558,9 @@ initialize_structseq_dict(PyStructSequence_Desc *desc, PyObject* dict,

// Set _fields_defaults to an empty dir, as we don't support defaults
defaults = PyDict_New();
if (!defaults)
if (!defaults) {
goto error;
}

if (PyDict_SetItemString(dict, named_fields_defaults_key, defaults) < 0) {
goto error;
Expand Down