Skip to content

gh-108388: regrtest runs slowest tests first #108391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 3 commits into from
Closed

gh-108388: regrtest runs slowest tests first #108391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
852b6a2
gh-108388: regrtest runs slowest tests first
vstinner Aug 24, 2023
9d5c203
Revert "test_peg_generator and test_freeze require cpu (#108386)"
vstinner Aug 24, 2023
3345a17
DEBUG: Log the 20 slowest tests
vstinner Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "test_peg_generator and test_freeze require cpu (#108386)" 
This reverts commit 7a6cc3e.
  • Loading branch information
@vstinner
vstinner committed Aug 24, 2023
commit 9d5c2033cf5cbb0a9a29658bd19806e071a33eb6
6 changes: 4 additions & 2 deletions Lib/test/test_peg_generator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
from test.support import load_package_tests


# Creating a virtual environment and building C extensions is slow
support.requires('cpu')
if support.check_sanitizer(address=True, memory=True):
# gh-90791: Skip the test because it is too slow when Python is built
# with ASAN/MSAN: between 5 and 20 minutes on GitHub Actions.
raise unittest.SkipTest("test too slow on ASAN/MSAN build")


# Load all tests in package
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_tools/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
from test.support import import_helper


if support.check_sanitizer(address=True, memory=True):
# gh-90791: Skip the test because it is too slow when Python is built
# with ASAN/MSAN: between 5 and 20 minutes on GitHub Actions.
raise unittest.SkipTest("test too slow on ASAN/MSAN build")


if not support.has_subprocess_support:
raise unittest.SkipTest("test module requires subprocess")

Expand Down
3 changes: 0 additions & 3 deletions Lib/test/test_tools/test_freeze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
class TestFreeze(unittest.TestCase):

def test_freeze_simple_script(self):
# Building Python is slow
support.requires('cpu')

script = textwrap.dedent("""
import sys
print('running...')
Expand Down