Skip to content

gh-106016: Support customizing of module attributes access with __setattr__/__delattr__ (PEP 726) #108261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skirpichev wants to merge 21 commits into from
Closed

gh-106016: Support customizing of module attributes access with __setattr__/__delattr__ (PEP 726) #108261

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a840465
gh-106016: Support customizing of module attributes access with __set…
skirpichev Apr 1, 2023
3e78225
Update Doc/reference/datamodel.rst
skirpichev Aug 22, 2023
0a8cec6
Update Doc/reference/datamodel.rst
skirpichev Aug 22, 2023
2904f50
Update Doc/reference/datamodel.rst
skirpichev Aug 22, 2023
bce1667
Drop PyErr_Clear()
skirpichev Aug 22, 2023
bcafd0d
move delattr/setattr declarations
skirpichev Aug 22, 2023
0740efb
m -> mod
skirpichev Aug 22, 2023
74c3d13
Check PyObject_CallFunctionObjArgs return value
skirpichev Aug 22, 2023
83c4c50
Document changes in the "Other Language Changes" section
skirpichev Aug 22, 2023
7fe6a06
Use PyDict_GetItemRef instead of PyDict_GetItemWithError
skirpichev Aug 22, 2023
47d93ce
Move test modules to Lib/test/test_module/
skirpichev Aug 22, 2023
f3f796d
Avoid ret variable
skirpichev Aug 23, 2023
f971a22
+Py_DECREF
skirpichev Aug 23, 2023
68eefbd
Reorder setattr/delattr paths
skirpichev Aug 23, 2023
048d8bf
Merge branch 'main' into module-setdelattr
skirpichev Aug 23, 2023
058412e
Apply suggestions from code review
skirpichev Aug 24, 2023
49c82c5
Update Lib/test/test_module/__init__.py
skirpichev Aug 24, 2023
280fc0e
Merge branch 'main' into module-setdelattr
skirpichev Aug 24, 2023
dafc546
Merge branch 'main' into module-setdelattr
skirpichev Oct 7, 2023
9dcacaf
Merge branch 'main' into module-setdelattr
skirpichev Feb 25, 2024
cd0e4be
Mention PEP in docs, like PEP 562
skirpichev Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check PyObject_CallFunctionObjArgs return value
  • Loading branch information
@skirpichev
skirpichev committed Aug 22, 2023
commit 74c3d138ce75d08470e0e76571ce77424c3597c1
9 changes: 5 additions & 4 deletions Objects/moduleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,15 +869,16 @@ _Py_module_getattro(PyModuleObject *m, PyObject *name)
static int
module_setattro(PyModuleObject *mod, PyObject *name, PyObject *value)
{
PyObject *ret;
assert(mod->md_dict != NULL);
if (value == NULL) {
Comment thread
skirpichev marked this conversation as resolved.
Outdated
PyObject *delattr = PyDict_GetItemWithError(mod->md_dict, &_Py_ID(__delattr__));
if (PyErr_Occurred()) {
return -1;
}
if (delattr) {
PyObject_CallFunctionObjArgs(delattr, name, NULL);
if (PyErr_Occurred()) {
ret = PyObject_CallFunctionObjArgs(delattr, name, NULL);
if (ret == NULL) {
return -1;
}
Comment thread
skirpichev marked this conversation as resolved.
return 0;
Expand All @@ -888,8 +889,8 @@ module_setattro(PyModuleObject *mod, PyObject *name, PyObject *value)
return -1;
}
if (setattr) {
PyObject_CallFunctionObjArgs(setattr, name, value, NULL);
if (PyErr_Occurred()) {
ret = PyObject_CallFunctionObjArgs(setattr, name, value, NULL);
if (ret == NULL) {
return -1;
}
return 0;
Expand Down