Skip to content

gh-104504: cases generator: Add --warn-unreachable to the mypy config #108112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 9 commits into from
Aug 20, 2023
Merged

gh-104504: cases generator: Add --warn-unreachable to the mypy config #108112

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
833586f
Improve the GitHub issue forms
AlexWaygood Aug 17, 2023
c0a42bc
Merge branch 'main' of https://github.com/python/cpython
AlexWaygood Aug 18, 2023
ba097e0
cases generator: Add `--warn-unreachable` to the mypy config
AlexWaygood Aug 18, 2023
e4a9e06
Actually assign it
AlexWaygood Aug 18, 2023
82bc6f6
Merge branch 'main' of https://github.com/python/cpython
AlexWaygood Aug 20, 2023
a27ffa0
Merge branch 'main' into cases-generator-reachability
AlexWaygood Aug 20, 2023
2f5206d
Fix one of the two locations
AlexWaygood Aug 20, 2023
ec78f7c
Fix the other one
AlexWaygood Aug 20, 2023
8497a68
Revert unrelated changes
AlexWaygood Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the other one
  • Loading branch information
@AlexWaygood
AlexWaygood committed Aug 20, 2023
commit ec78f7c69e60aa50bb038b76143c261d37b9d5b8
6 changes: 2 additions & 4 deletions Tools/cases_generator/generate_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ def write_metadata(self, metadata_filename: str, pymetadata_filename: str) -> No
# Compute the set of all instruction formats.
all_formats: set[str] = set()
for thing in self.everything:
format: str | None = None
match thing:
case OverriddenInstructionPlaceHolder():
continue
Expand All @@ -384,14 +383,13 @@ def write_metadata(self, metadata_filename: str, pymetadata_filename: str) -> No
case parsing.Macro():
format = self.macro_instrs[thing.name].instr_fmt
case parsing.Pseudo():
for target in self.pseudos[thing.name].targets:
for idx, target in enumerate(self.pseudos[thing.name].targets):
target_instr = self.instrs.get(target)
assert target_instr
if format is None:
if idx == 0:
format = target_instr.instr_fmt
else:
assert format == target_instr.instr_fmt
assert format is not None
case _:
assert_never(thing)
all_formats.add(format)
Comment on lines +389 to 395

@gvanrossum gvanrossum Aug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ditto here for format.

Expand Down