Skip to content

gh-106659: Fix test_embed.test_forced_io_encoding() on Windows #108010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Aug 16, 2023
Merged

gh-106659: Fix test_embed.test_forced_io_encoding() on Windows #108010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
592f255
gh-106659: Fix test_embed.test_forced_io_encoding() on Windows
vstinner Aug 16, 2023
3a3983f
Add #ifdef MS_WINDOWS
vstinner Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-106659: Fix test_embed.test_forced_io_encoding() on Windows 
Use config.legacy_windows_stdio=1 to avoid _io._WindowsConsoleIO.
  • Loading branch information
@vstinner
vstinner committed Aug 16, 2023
commit 592f255c334162800b7bbae939c751b74eabf8ed
3 changes: 2 additions & 1 deletion Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,8 @@ Removed
* ``Py_SetPath()``: set :c:member:`PyConfig.module_search_paths` instead.
* ``Py_SetProgramName()``: set :c:member:`PyConfig.program_name` instead.
* ``Py_SetPythonHome()``: set :c:member:`PyConfig.home` instead.
* ``Py_SetStandardStreamEncoding()``: set :c:member:`PyConfig.stdio_encoding` instead.
* ``Py_SetStandardStreamEncoding()``: set :c:member:`PyConfig.stdio_encoding`
instead, and set also maybe :c:member:`PyConfig.legacy_windows_stdio`.
* ``_Py_SetProgramFullPath()``: set :c:member:`PyConfig.executable` instead.

Use the new :c:type:`PyConfig` API of the :ref:`Python Initialization
Expand Down
3 changes: 3 additions & 0 deletions Programs/_testembed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,9 @@ static void check_stdio_details(const wchar_t *encoding, const wchar_t *errors)
if (errors) {
config_set_string(&config, &config.stdio_errors, errors);
}
// gh-106659: On Windows, don't use _io._WindowsConsoleIO which always
// announce UTF-8 for sys.stdin.encoding.
config.legacy_windows_stdio = 1;
Comment thread
Eclips4 marked this conversation as resolved.
config_set_program_name(&config);
init_from_config_clear(&config);

Expand Down