Skip to content

gh-107972: Argument Clinic: Ensure a C basename is provided after 'as' #107973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 6 commits into from
Aug 15, 2023
Merged

gh-107972: Argument Clinic: Ensure a C basename is provided after 'as' #107973

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
376fd15
gh-107972: Argument Clinic: Ensure a C basename is provided after 'as'
erlend-aasland Aug 15, 2023
00b704f
Fixup test
erlend-aasland Aug 15, 2023
7e77c09
Apply style suggestions from code review
erlend-aasland Aug 15, 2023
60c05d3
Improve the clone test
erlend-aasland Aug 15, 2023
80fbc4d
No need for output block, though
erlend-aasland Aug 15, 2023
d50a1e4
Pull in main
erlend-aasland Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pull in main
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 15, 2023
commit d50a1e422057fec9e20a75130b544e77e6e8b278
30 changes: 30 additions & 0 deletions Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,35 @@ def test_directive_output_invalid_command(self):
"""
self.expect_failure(block, err, lineno=2)

def test_validate_cloned_init(self):
block = """
/*[clinic input]
class C "void *" ""
C.meth
a: int
[clinic start generated code]*/
/*[clinic input]
@classmethod
C.__init__ = C.meth
[clinic start generated code]*/
"""
err = "'__init__' must be a normal method, not a class or static method"
self.expect_failure(block, err, lineno=8)

def test_validate_cloned_new(self):
block = """
/*[clinic input]
class C "void *" ""
C.meth
a: int
[clinic start generated code]*/
/*[clinic input]
C.__new__ = C.meth
[clinic start generated code]*/
"""
err = "'__new__' must be a class method"
self.expect_failure(block, err, lineno=7)

def test_no_c_basename_cloned(self):
block = """
/*[clinic input]
Expand All @@ -625,6 +654,7 @@ def test_no_c_basename_cloned(self):
self.expect_failure(block, err, lineno=5)



class ParseFileUnitTest(TestCase):
def expect_parsing_failure(
self, *, filename, expected_error, verify=True, output=None
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.