Skip to content

gh-104683: Argument Clinic: Extract parse_function_names() helper #107964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 12 commits into from
Aug 16, 2023
Merged

gh-104683: Argument Clinic: Extract parse_function_names() helper #107964

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2f53112
gh-104683: Argument Clinic: Extract parse_names() helper
erlend-aasland Aug 15, 2023
76b637a
Ensure a C basename is provided after 'as'
erlend-aasland Aug 15, 2023
0243b09
Add test_no_c_basename()
erlend-aasland Aug 15, 2023
f2aefff
Pull in main
erlend-aasland Aug 15, 2023
06d4f62
Pull in main
erlend-aasland Aug 15, 2023
4620731
Pull in main
erlend-aasland Aug 15, 2023
3f63df9
Adjust test
erlend-aasland Aug 15, 2023
2e68f63
Style
erlend-aasland Aug 16, 2023
df8a2cc
Pull in main
erlend-aasland Aug 16, 2023
a915dc9
Use a named tuple
erlend-aasland Aug 16, 2023
3735c95
Update Tools/clinic/clinic.py
erlend-aasland Aug 16, 2023
2ee0340
Improved function name
erlend-aasland Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pull in main
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 15, 2023
commit f2aefff4ce74e49e806214444d2d3315f99e417c
15 changes: 15 additions & 0 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4848,6 +4848,21 @@ def parse_names(line: str) -> tuple[str, str]:
fail(f"Illegal C basename: {c_basename!r}")
return full_name, c_basename

def update_function_kind(self, fullname: str) -> None:
fields = fullname.split('.')
name = fields.pop()
_, cls = self.clinic._module_and_class(fields)
if name in unsupported_special_methods:
fail(f"{name!r} is a special method and cannot be converted to Argument Clinic!")
if name == '__new__':
if (self.kind is not CLASS_METHOD) or (not cls):
fail("'__new__' must be a class method!")
self.kind = METHOD_NEW
elif name == '__init__':
if (self.kind is not CALLABLE) or (not cls):
fail("'__init__' must be a normal method, not a class or static method!")
self.kind = METHOD_INIT

def state_modulename_name(self, line: str) -> None:
# looking for declaration, which establishes the leftmost column
# line should be
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.