Skip to content

gh-93057: Deprecate positional use of optional sqlite3.connect() params #107948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
Aug 15, 2023
Merged

gh-93057: Deprecate positional use of optional sqlite3.connect() params #107948

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
40996ef
gh-93057: Deprecate positional use of optional sqlite3.connect() params
erlend-aasland Aug 14, 2023
b84ee0e
Fix test and news entries
erlend-aasland Aug 14, 2023
6ab04fd
regen clinic
erlend-aasland Aug 14, 2023
01c4067
Address review: don't repeat the what's new entry
erlend-aasland Aug 14, 2023
de7e87c
Manually insert deprecation warning for sqlite3.connect
erlend-aasland Aug 15, 2023
6f3e5c6
Pull in main
erlend-aasland Aug 15, 2023
4018bd9
Also test module level connect()
erlend-aasland Aug 15, 2023
1f48783
Also mention the Connection constructor in What's New/NEWS
erlend-aasland Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Manually insert deprecation warning for sqlite3.connect
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 15, 2023
commit de7e87cc0733b90c2693becac059dd72b58e925a
11 changes: 11 additions & 0 deletions Modules/_sqlite/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ pysqlite_connect(PyObject *module, PyObject *const *args, Py_ssize_t nargsf,

static const int FACTORY_POS = 5;
Py_ssize_t nargs = PyVectorcall_NARGS(nargsf);
if (nargs > 1 && nargs <= 8) {
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"Passing more than 1 positional argument to sqlite3.connect()"
" is deprecated. Parameters 'timeout', 'detect_types', "
"'isolation_level', 'check_same_thread', 'factory', "
"'cached_statements' and 'uri' will become keyword-only "
"parameters in Python 3.15.", 1))
{
return NULL;
}
}
if (nargs > FACTORY_POS) {
factory = args[FACTORY_POS];
}
Expand Down