Skip to content

gh-106368: Argument clinic: add tests for more failure paths #107731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 3 commits into from
Aug 8, 2023
Merged

gh-106368: Argument clinic: add tests for more failure paths #107731

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8400b67
Argument clinic: add tests for more failure paths
AlexWaygood Aug 7, 2023
a93ce1a
Merge branch 'main' into clinic-more-coverage
AlexWaygood Aug 8, 2023
bec0b72
Remove redundant tests
AlexWaygood Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant tests
  • Loading branch information
@AlexWaygood
AlexWaygood committed Aug 8, 2023
commit bec0b72808586245e9c1780d33b5288fbbb2bc93
26 changes: 0 additions & 26 deletions Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,20 +1244,6 @@ def test_left_group(self):
Attributes for the character.
""")

def test_unmatched_right_square_paren(self):
err = "Function 'addch' has a ']' without a matching '['."
block = """
module curses
curses.addch
y: int
Y-coordinate.
x: int
X-coordinate.
]
/
"""
self.expect_failure(block, err, lineno=6)

def test_nested_groups(self):
function = self.parse_function("""
module curses
Expand Down Expand Up @@ -1520,18 +1506,6 @@ def test_parameters_required_after_star(self):
with self.subTest(block=block):
self.expect_failure(block, err)

def test_parameters_required_after_depr_star(self):
dataset = (
"module foo\nfoo.bar\n * [from 3.14]",
"module foo\nfoo.bar\n * [from 3.14]\nDocstring here.",
"module foo\nfoo.bar\n this: int\n * [from 3.14]",
"module foo\nfoo.bar\n this: int\n * [from 3.14]\nDocstring.",
)
err = "Function 'foo.bar' specifies '* [from 3.14]' without any parameters afterwards."
for block in dataset:
with self.subTest(block=block):
self.expect_failure(block, err)

def test_depr_star_invalid_format_1(self):
block = """
module foo
Expand Down