Skip to content

gh-104683: Argument Clinic: refactor format_docstring() #107623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 9 commits into from
Aug 8, 2023
Merged

gh-104683: Argument Clinic: refactor format_docstring() #107623

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd632eb
gh-104683: Argument Clinic: refactor format_docstring()
erlend-aasland Aug 4, 2023
1d244dc
Use splitlines() iso. comprehension
erlend-aasland Aug 4, 2023
9d3ed09
Revert "Use splitlines() iso. comprehension"
erlend-aasland Aug 4, 2023
0902130
Split, not splitlines
erlend-aasland Aug 4, 2023
e3ff673
Style
erlend-aasland Aug 8, 2023
e041288
Merge branch 'main' into clinic/refactor-format-docstring
erlend-aasland Aug 8, 2023
34729c2
Fix mypy
erlend-aasland Aug 8, 2023
03a9f16
Pull in main
erlend-aasland Aug 8, 2023
4b0c7ec
Remove one more unneeded rstrip
erlend-aasland Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Use splitlines() iso. comprehension" 
This reverts commit 1d244dc.
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 4, 2023
commit 9d3ed09e64b23885c5f774610384929fa15bf8a8
2 changes: 1 addition & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5520,7 +5520,7 @@ def format_docstring(self) -> str:
# Guido said Clinic should enforce this:
# http://mail.python.org/pipermail/python-dev/2013-June/127110.html

lines = f.docstring.splitlines()
lines = [line for line in f.docstring.split('\n')]
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
if len(lines) >= 2:
if lines[1]:
fail("Docstring for " + f.full_name + " does not have a summary line!\n" +
Expand Down