Skip to content

gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" #107542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 6 commits into from
Aug 21, 2023
Merged

gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" #107542

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db35ad9
gh-107526: Revert "gh-100357: Convert several functions in bltinsmodu…
sobolevn Aug 1, 2023
9aa7e57
Run `make clinic`
sobolevn Aug 1, 2023
00b6540
Merge branch 'main' into issue-107526
sobolevn Aug 9, 2023
e1b491b
Address review
sobolevn Aug 9, 2023
a7a41ce
Remove NEWS entry
sobolevn Aug 9, 2023
b8371ac
Add NEWS entry about revert
sobolevn Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Aug 9, 2023
commit e1b491bf69f536d9d7bc5cd7c43a570bf3cb2c01
2 changes: 1 addition & 1 deletion Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2447,7 +2447,7 @@ builtin_vars(PyObject *self, PyObject *args)
if (!PyArg_UnpackTuple(args, "vars", 0, 1, &v))
return NULL;
if (v == NULL) {
d = Py_XNewRef(PyEval_GetLocals());
d = _PyEval_GetFrameLocals();
}
else {
if (PyObject_GetOptionalAttr(v, &_Py_ID(__dict__), &d) == 0) {
Expand Down