Skip to content

gh-104050: Argument clinic: enable mypy's --warn-return-any setting #107405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 4 commits into from
Jul 29, 2023
Merged

gh-104050: Argument clinic: enable mypy's --warn-return-any setting #107405

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdd377c
Argument clinic: enable mypy's `--warn-return-any` setting
AlexWaygood Jul 28, 2023
a5103be
add an essay explaining the return annotation
AlexWaygood Jul 28, 2023
8aed224
Revert "add an essay explaining the return annotation"
AlexWaygood Jul 29, 2023
6df4ba3
Improve docstring slightly
AlexWaygood Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add an essay explaining the return annotation
  • Loading branch information
@AlexWaygood
AlexWaygood authored Jul 28, 2023
commit a5103bef7682f04062c393fae08584f3905f8ed3
5 changes: 5 additions & 0 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4283,6 +4283,11 @@ class float_return_converter(double_return_converter):
cast = '(double)'


# What do we do in this function?
# We take an arbitrary AST node, compile the node into a function object,
# call that function with 0 arguments, and return whatever the call returns.
# The only possible return annotations here would be `object` or `Any`,
# and `object` would be too annoying. Return `Any`!
def eval_ast_expr(
node: ast.expr,
globals: dict[str, Any],
Expand Down