Skip to content

gh-107369: optimize textwrap.indent() #107374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 8 commits into from
Jul 29, 2023
Merged

gh-107369: optimize textwrap.indent() #107374

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
94ab051
optimize textwrap.indent()
methane Jul 28, 2023
8c5896c
Add NEWS
methane Jul 28, 2023
6ee731c
Add what's new entry
methane Jul 28, 2023
fad98a2
Use lstrip instead of strip
methane Jul 28, 2023
4c6a46a
avoid temporary tuple.
methane Jul 29, 2023
5e60878
use str.isspace instead of lstrip
methane Jul 29, 2023
16e3dbd
add comment about splitlines(True)
methane Jul 29, 2023
734fd01
25% -> 30%
methane Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ typing
Optimizations
=============


* :func:`textwrap.indent` is now ~25% faster than before for large input.
(Contributed by Inada Naoki in :gh:`107369`.)


Deprecated
Expand Down
15 changes: 9 additions & 6 deletions Lib/textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,13 +476,16 @@ def indent(text, prefix, predicate=None):
consist solely of whitespace characters.
"""
if predicate is None:
def predicate(line):
return line.strip()
predicate = str.lstrip

def prefixed_lines():
for line in text.splitlines(True):
yield (prefix + line if predicate(line) else line)
return ''.join(prefixed_lines())
prefixed_lines = []
for line in text.splitlines(True):
if predicate(line):
prefixed_lines.extend((prefix, line))
Comment thread
methane marked this conversation as resolved.
Outdated
else:
prefixed_lines.append(line)

return ''.join(prefixed_lines)


if __name__ == "__main__":
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-07-28-14-56-35.gh-issue-107369.bvTq8F.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Optimize :func:`textwrap.indent`. It is ~25% faster for large input. Patch
by Inada Naoki.