Skip to content

gh-82500: Fix asyncio sendfile overflow on 32bit #107056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 5 commits into from
Jul 23, 2023
Merged

gh-82500: Fix asyncio sendfile overflow on 32bit #107056

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
231b64f
gh-82500: Fix asyncio sendfile overflow on 32bit
bdraco Jul 22, 2023
f02d940
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 22, 2023
f25bba1
Update Lib/asyncio/unix_events.py
bdraco Jul 23, 2023
c83dd4b
Update Misc/NEWS.d/next/Library/2023-07-22-16-44-58.gh-issue-82500.cQ…
bdraco Jul 23, 2023
bde4502
use suggested min expression
bdraco Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use suggested min expression
  • Loading branch information
@bdraco
bdraco committed Jul 23, 2023
commit bde4502f12fe3dfff4c230da73cd67bfe7b9e981
3 changes: 1 addition & 2 deletions Lib/asyncio/unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,7 @@ def _sock_sendfile_native_impl(self, fut, registered_fd, sock, fileno,
return

# On 32-bit architectures truncate to 1GiB to avoid OverflowError
if sys.maxsize < 2 ** 32:
blocksize = min(blocksize, 2 ** 30)
blocksize = min(blocksize, sys.maxsize//2 + 1)

try:
sent = os.sendfile(fd, fileno, offset, blocksize)
Expand Down