Skip to content

gh-106527: asyncio: optimize to add/remove readers and writers #106528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 8 commits into from
Jul 22, 2023
Merged

gh-106527: asyncio: optimize to add/remove readers and writers #106528

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa39201
Reduce overhead to add and remove asyncio readers and writers
bdraco Jul 7, 2023
df47703
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 7, 2023
c3d04e7
refactor tests
bdraco Jul 7, 2023
4146a55
Merge remote-tracking branch 'origin/optimize_adding_removing_asyncio…
bdraco Jul 7, 2023
a06d56f
fix refactoring error
bdraco Jul 7, 2023
e9f4079
cleanups
bdraco Jul 12, 2023
98e5dad
Update 2023-07-07-18-22-07.gh-issue-106527.spHQ0W.rst
methane Jul 22, 2023
2730370
Merge branch 'main' into optimize_adding_removing_asyncio_writers
bdraco Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanups
  • Loading branch information
@bdraco
bdraco committed Jul 12, 2023
commit e9f4079c50e73741af038d95a01aa923b0c10b96
48 changes: 24 additions & 24 deletions Lib/asyncio/selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,19 +290,20 @@ def _remove_reader(self, fd):
if self.is_closed():
return False
key = self._selector.get_map().get(fd)
if key is not None:
mask, (reader, writer) = key.events, key.data
mask &= ~selectors.EVENT_READ
if not mask:
self._selector.unregister(fd)
else:
self._selector.modify(fd, mask, (None, writer))
if key is None:
return False
mask, (reader, writer) = key.events, key.data
mask &= ~selectors.EVENT_READ
if not mask:
self._selector.unregister(fd)
else:
self._selector.modify(fd, mask, (None, writer))

if reader is not None:
reader.cancel()
return True
else:
return False
if reader is not None:
reader.cancel()
return True
else:
return False

def _add_writer(self, fd, callback, *args):
self._check_closed()
Expand All @@ -326,20 +327,19 @@ def _remove_writer(self, fd):
key = self._selector.get_map().get(fd)
if key is None:
return False
mask, (reader, writer) = key.events, key.data
# Remove both writer and connector.
mask &= ~selectors.EVENT_WRITE
if not mask:
self._selector.unregister(fd)
else:
mask, (reader, writer) = key.events, key.data
# Remove both writer and connector.
mask &= ~selectors.EVENT_WRITE
if not mask:
self._selector.unregister(fd)
else:
self._selector.modify(fd, mask, (reader, None))
self._selector.modify(fd, mask, (reader, None))

if writer is not None:
writer.cancel()
return True
else:
return False
if writer is not None:
writer.cancel()
return True
else:
return False

def add_reader(self, fd, callback, *args):
"""Add a reader callback."""
Expand Down