Skip to content

bpo-9566: Fix compiler warnings in peephole.c #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Dec 7, 2018
Merged

bpo-9566: Fix compiler warnings in peephole.c #10652

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f0f306
bpo-9566: Fix compiler warnings in peephole.c
vstinner Dec 1, 2018
b097f36
Fix issues with signed vs unsigned
vstinner Dec 6, 2018
0133edb
Move comment
vstinner Dec 7, 2018
0afc918
Add ilen variable
vstinner Dec 7, 2018
341e474
Add "#if SIZEOF_SIZE_T > SIZEOF_INT"
vstinner Dec 7, 2018
7a97ab6
Fix #if
vstinner Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix #if
  • Loading branch information
@vstinner
vstinner committed Dec 7, 2018
commit 7a97ab6f663b39acd5df0920e04f53fec23588dc
2 changes: 1 addition & 1 deletion Python/peephole.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ fold_tuple_on_constants(_Py_CODEUNIT *codestr, Py_ssize_t codelen,
PyTuple_SET_ITEM(newconst, i, constant);
}

#if SIZEOF_SIZE_T > SIZEOF_INT
Py_ssize_t index = PyList_GET_SIZE(consts);
Comment thread
vstinner marked this conversation as resolved.
#if SIZEOF_SIZE_T > SIZEOF_INT
if ((size_t)index >= UINT_MAX - 1) {
Comment thread
vstinner marked this conversation as resolved.
Py_DECREF(newconst);
PyErr_SetString(PyExc_OverflowError, "too many constants");
Expand Down