Skip to content

gh-106078: Convert _decimal types to heap types #106079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 18 commits into from
Jun 29, 2023
Merged

gh-106078: Convert _decimal types to heap types #106079

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
978e602
Move static type object to global state
CharlieZhao95 Jun 21, 2023
a16649b
Add NEWs entry
CharlieZhao95 Jun 25, 2023
3b4e823
Remove news entry
CharlieZhao95 Jun 26, 2023
bb4e191
Add Py_DEBUG
CharlieZhao95 Jun 26, 2023
3f44aed
Update Modules/_decimal/_decimal.c
CharlieZhao95 Jun 27, 2023
eb9d17f
Update Modules/_decimal/_decimal.c
CharlieZhao95 Jun 27, 2023
4faa645
Update Modules/_decimal/_decimal.c
CharlieZhao95 Jun 27, 2023
531bf03
Update Modules/_decimal/_decimal.c
CharlieZhao95 Jun 27, 2023
f445ab7
Apply erlend's comments
CharlieZhao95 Jun 27, 2023
ac05050
Change `CREATE_TYPE` param style
CharlieZhao95 Jun 27, 2023
78bf615
Modify `GLOBAL_STATE()` statement position
CharlieZhao95 Jun 27, 2023
b6e50c4
Add test cases
CharlieZhao95 Jun 28, 2023
514c839
Fix lint
CharlieZhao95 Jun 28, 2023
92a4c5f
Move tests to CWhitebox
CharlieZhao95 Jun 29, 2023
9e595e0
Update Modules/_decimal/_decimal.c
kumaraditya303 Jun 29, 2023
2f4f538
Merge branch 'main' into isolate-decimal-part1
kumaraditya303 Jun 29, 2023
a3df27a
Pull in main
erlend-aasland Jun 29, 2023
883c4f1
Match existing style in test_decimal.py
erlend-aasland Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Py_DEBUG
  • Loading branch information
@CharlieZhao95
CharlieZhao95 committed Jun 26, 2023
commit bb4e1911964ea6e0dfdbcdfbcdd5ef2c2e9e58ed
10 changes: 6 additions & 4 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2308,10 +2308,11 @@ PyDecType_FromFloatExact(PyTypeObject *type, PyObject *v,
mpd_t *d1, *d2;
uint32_t status = 0;
mpd_context_t maxctx;
decimal_state *state = GLOBAL_STATE();

#ifdef Py_DEBUG
decimal_state *state = GLOBAL_STATE();
assert(PyType_IsSubtype(type, state->PyDec_Type));

#endif
if (PyLong_Check(v)) {
return PyDecType_FromLongExact(type, v, context);
}
Expand Down Expand Up @@ -4606,10 +4607,11 @@ dec_richcompare(PyObject *v, PyObject *w, int op)
uint32_t status = 0;
int a_issnan, b_issnan;
int r;
decimal_state *state = GLOBAL_STATE();

#ifdef Py_DEBUG
decimal_state *state = GLOBAL_STATE();
assert(PyDec_Check(state, v));

#endif
CURRENT_CONTEXT(context);
CONVERT_BINOP_CMP(&a, &b, v, w, op, context);

Expand Down