Skip to content

GH-89812: Miscellaneous pathlib test improvements #106063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 5 commits into from
Jul 1, 2023
Merged

GH-89812: Miscellaneous pathlib test improvements #106063

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef08269
GH-89812: Miscellaneous pathlib test improvements
barneygale Jun 24, 2023
436fa3b
Remove unused `assertSame()` method
barneygale Jun 24, 2023
5096796
Fix misplaced `test_open_unbuffered()` method.
barneygale Jun 24, 2023
9c37a53
Fix direct reference to `pathlib.Path` in `test_glob_above_recursion_…
barneygale Jun 24, 2023
13fee78
Merge branch 'main' into gh-89812-pathlib-tests-misc
barneygale Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into gh-89812-pathlib-tests-misc
  • Loading branch information
@barneygale
barneygale committed Jul 1, 2023
commit 13fee7849ba13c2d6938951c5651dfba2f229fe9
10 changes: 2 additions & 8 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,14 +1628,6 @@ def cleanup():
# Broken symlink (pointing to itself).
os.symlink('brokenLinkLoop', join('brokenLinkLoop'))

if os.name == 'nt':
# Workaround for http://bugs.python.org/issue13772.
def dirlink(self, src, dest):
os.symlink(src, dest, target_is_directory=True)
else:
def dirlink(self, src, dest):
os.symlink(src, dest)

def assertFileNotFound(self, func, *args, **kwargs):
with self.assertRaises(FileNotFoundError) as cm:
func(*args, **kwargs)
Expand Down Expand Up @@ -2245,6 +2237,8 @@ def test_is_mount(self):
self.assertFalse((P / 'dirA').is_mount())
self.assertFalse((P / 'non-existing').is_mount())
self.assertFalse((P / 'fileA' / 'bah').is_mount())
if self.can_symlink:
self.assertFalse((P / 'linkA').is_mount())

def test_is_symlink(self):
P = self.cls(BASE)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.