Skip to content

gh-105858: Improve AST node constructors #105880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 18 commits into from
Feb 28, 2024
Merged

gh-105858: Improve AST node constructors #105880

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b1b73d9
gh-105858: Improve AST node constructors
JelleZijlstra Jun 17, 2023
d417cf3
Merge remote-tracking branch 'upstream/main' into astcons
JelleZijlstra Jun 22, 2023
c74740a
Fix subclasses
JelleZijlstra Jun 22, 2023
05d5569
Fix most deprecationwarnings in test_ast
JelleZijlstra Jun 22, 2023
f4b14ac
Merge remote-tracking branch 'upstream/main' into astcons
JelleZijlstra Oct 11, 2023
0efcdf3
Fix renamed function
JelleZijlstra Oct 11, 2023
f941696
Fix pickling; fix a refleak
JelleZijlstra Oct 11, 2023
4c42748
Fix other refleak
JelleZijlstra Oct 11, 2023
1a9b872
Merge branch 'main' into astcons
JelleZijlstra Oct 24, 2023
db16cc7
Merge branch 'main' into astcons
JelleZijlstra Feb 18, 2024
6bf677b
Update Parser/asdl_c.py
JelleZijlstra Feb 18, 2024
a2442b6
fix merge
JelleZijlstra Feb 18, 2024
5a1d37a
Expand NEWS
JelleZijlstra Feb 21, 2024
c4627a1
Merge remote-tracking branch 'upstream/main' into astcons
JelleZijlstra Feb 25, 2024
1f85438
docs
JelleZijlstra Feb 25, 2024
ff0cc67
Apply suggestions from code review
JelleZijlstra Feb 25, 2024
54cf55f
Merge remote-tracking branch 'upstream/main' into astcons
JelleZijlstra Feb 27, 2024
4bb0656
Reword Whats New note (based on suggestion by Alex Waygood)
JelleZijlstra Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into astcons
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Oct 11, 2023
commit f4b14acdf2028308481785670e0a878b2be1f891
2 changes: 1 addition & 1 deletion Parser/asdl_c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ def visitModule(self, mod):
Py_ssize_t i, numfields = 0;
int res = -1;
PyObject *key, *value, *fields, *remaining_fields = NULL;
if (_PyObject_LookupAttr((PyObject*)Py_TYPE(self), state->_fields, &fields) < 0) {
if (PyObject_GetOptionalAttr((PyObject*)Py_TYPE(self), state->_fields, &fields) < 0) {
goto cleanup;
}
if (fields) {
Expand Down
2 changes: 1 addition & 1 deletion Python/Python-ast.c
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

You are viewing a condensed version of this merge commit. You can view the full changes here.