Skip to content

GH-105848: Get rid of KW_NAMES #105849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandtbucher wants to merge 13 commits into from
Closed

GH-105848: Get rid of KW_NAMES #105849

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
28adc90
Replace KW_NAMES with LOAD_CONST/PUSH_NULL
brandtbucher Jun 11, 2023
3aff105
Catch up with main
brandtbucher Jun 15, 2023
fc8176e
Bump magic number
brandtbucher Jun 16, 2023
dbda923
blurb add
brandtbucher Jun 16, 2023
8c414e5
Fix up the dis docs for CALL
brandtbucher Jun 16, 2023
abfd56a
Catch up with main
brandtbucher Jun 16, 2023
538633f
make patchcheck
brandtbucher Jun 16, 2023
f9a9aab
Fix doctests
brandtbucher Jun 16, 2023
a1640c7
Catch up with main
brandtbucher Jun 16, 2023
8da9d14
Use the low bit of CALL for kwnames
brandtbucher Jun 16, 2023
b022837
Fix blurb
brandtbucher Jun 16, 2023
408c615
fixup
brandtbucher Jun 16, 2023
47205b2
Remove bad blurb
brandtbucher Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix blurb
  • Loading branch information
@brandtbucher
brandtbucher committed Jun 16, 2023
commit b02283782f7c8a77f51067727b3e84a2b5732f4d
3 changes: 1 addition & 2 deletions Misc/NEWS.d/next/Core and Builtins/2023-06-15-22-57-23.gh-issue-105848._gxL3O.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Replace the ``KW_NAMES`` opcode with either a :opcode:`PUSH_NULL` or a
:opcode:`LOAD_CONST` immediately before all :opcode:`CALL` instructions.
Replace the ``KW_NAMES`` opcode with a flag on the low bit of :opcode:`CALL` instructions indicating the presence of keyword names on the stack.
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-06-16-03-03-39.gh-issue-105848.g0uVaB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Replace the ``KW_NAMES`` opcode with a flag on the low bit of :opcode:`CALL`
instructions indicating the presence of keyword names on the stack.