remove redundant C-contiguity check in binascii

serhiy-storchaka · Oct 23, 2023 · Jun 8, 2023 · Jun 8, 2023 · Jun 8, 2023 · Jun 8, 2023
commit 374f01ac2b2c72a314ac86160c768fbd2d22e892
diff --git a/Lib/test/test_binascii.py b/Lib/test/test_binascii.py
@@ -428,6 +428,12 @@ def test_b2a_base64_newline(self):
         self.assertEqual(binascii.b2a_base64(b, newline=False),
                          b'aGVsbG8=')
 
+    def test_c_contiguity(self):
+        m = memoryview(bytearray(b'noncontig'))
+        noncontig_writable = m[::-2]
+        with self.assertRaises(BufferError):
+            binascii.b2a_hex(noncontig_writable)
+
 
 class ArrayBinASCIITest(BinASCIITest):
     def type2test(self, s):

diff --git a/Modules/binascii.c b/Modules/binascii.c
@@ -185,13 +185,6 @@ ascii_buffer_converter(PyObject *arg, Py_buffer *buf)
                      "not '%.100s'", Py_TYPE(arg)->tp_name);
         return 0;
     }
-    if (!PyBuffer_IsContiguous(buf, 'C')) {
-        PyErr_Format(PyExc_TypeError,
-                     "argument should be a contiguous buffer, "
-                     "not '%.100s'", Py_TYPE(arg)->tp_name);
-        PyBuffer_Release(buf);
-        return 0;
-    }
     return Py_CLEANUP_SUPPORTED;
 }