Skip to content

Use CSV-separated outputs @ get-changed-files @ CI #105151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 9 commits into from
Jun 21, 2023
Merged

Use CSV-separated outputs @ get-changed-files @ CI #105151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b0020f
Revert "CI: Temporarily skip paths with spaces to avoid error (#105110)"
webknjaz May 31, 2023
9517c21
Use CSV-separated outputs @ get-changed-files @ CI
webknjaz May 31, 2023
03e0e4c
Add --clean arg to take a list of comma-seperated files to touch
hugovk Jun 1, 2023
1484c9f
React to any "build changed files" command failure
webknjaz Jun 4, 2023
8fd85ab
Quote `touch-clean-files.py --clean` argument
webknjaz Jun 4, 2023
f5a5220
No-op fast with empty `--clean` passed for touch
webknjaz Jun 4, 2023
5a9787b
Apply csv arg code comments by Hugo
webknjaz Jun 4, 2023
3e6f488
Refer to `exit` from `sys` explicitly
webknjaz Jun 5, 2023
d19d319
Merge branch 'main' into maintenance/gha-reusable-docs-workflow--Ana0…
hugovk Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use CSV-separated outputs @ get-changed-files @ CI 
This is necessary because paths with whitespaces tend to crash said
action[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.

The change fixes [[4]]

[1]: https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited
[2]: #103914 (comment)
[3]: #103914 (comment)
[4]: #103914 (comment)
  • Loading branch information
@webknjaz
webknjaz committed May 31, 2023
commit 9517c2171c5b4b432c055d80f8a431b713b7887e
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
Doc/**
Misc/**
.github/workflows/reusable-docs.yml
format: csv # unbreaks paths /w whitespaces; json is harder to parse
Comment thread
webknjaz marked this conversation as resolved.
Outdated
- name: Check for docs changes
if: >-
github.event_name == 'pull_request'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/reusable-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
uses: Ana06/get-changed-files@v2.2.0
with:
filter: "Doc/**"
format: csv # unbreaks paths /w whitespaces; json is harder to parse
Comment thread
webknjaz marked this conversation as resolved.
Outdated
- name: 'Build changed files in nit-picky mode'
if: github.event_name == 'pull_request'
continue-on-error: true
Expand Down