Skip to content

gh-102988: Detect email address parsing errors and return empty tuple to indicate the parsing error (old API) #105127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 9 commits into from
Jul 10, 2023
Merged

gh-102988: Detect email address parsing errors and return empty tuple to indicate the parsing error (old API) #105127

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81098ed
gh-102988: Detect email address parsing errors and return empty tuple…
tdwyer May 31, 2023
ecbb31c
r-prefix strs with \ in the tests
gpshead May 31, 2023
d8d2831
reword getaddresses docstring
gpshead May 31, 2023
b44a0b7
Update comment for getaddresses() and fix broken email test
tdwyer Jun 7, 2023
40002d9
Add NEWS
tdwyer Jun 14, 2023
86ffb57
Merge branch 'main' into fix_issues102988
gpshead Jun 21, 2023
302ee76
Fix NEWS entry. It was not a Module its Class email._parseaddr.Addres…
tdwyer Jun 21, 2023
48d9f58
Add email.utils docs, narrow the docstring.
gpshead Jul 10, 2023
f96a3ff
Add versionchanged to parseaddr, add What's New.
gpshead Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reword getaddresses docstring
  • Loading branch information
@gpshead
gpshead authored May 31, 2023
commit d8d283103938bf90bd8b904dec34251d9f7403e1
7 changes: 4 additions & 3 deletions Lib/email/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,10 @@ def _post_parse_validation(parsed_email_header_tuples):


def getaddresses(fieldvalues):
"""Return a list of (REALNAME, EMAIL) for each fieldvalue,
unless the parse fails, in which case return a 2-tuple of ('', '')
will be returned in it's place.
"""Return a list of (REALNAME, EMAIL) or ('','') for each fieldvalue.

Comment thread
tdwyer marked this conversation as resolved.
Outdated
When parsing fails for a fieldvalue, a 2-tuple of ('', '') is returned in
its place.

If the resulting list is greater than number of items in the fieldvalues
Comment thread
tdwyer marked this conversation as resolved.
Outdated
list, a list containing a single empty 2-tuple [('', '')] will be returned.
Expand Down