Skip to content

gh-104146: Purge dead code from Argument Clinic #104680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 3 commits into from
May 20, 2023
Merged

gh-104146: Purge dead code from Argument Clinic #104680

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9395dd7
gh-104146: Purge dead code from Argument Clinic
erlend-aasland May 20, 2023
09c8df4
Use pop, but discard value
erlend-aasland May 20, 2023
396f0df
use slices
AlexWaygood May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use pop, but discard value
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 20, 2023
commit 09c8df47c3dffed62433ea90921b48a321e57af4
3 changes: 2 additions & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4237,7 +4237,8 @@ def directive_version(self, required):
fail("Insufficient Clinic version!\n Version: " + version + "\n Required: " + required)

def directive_module(self, name):
fields = name.split('.')[1:]
fields = name.split('.')
_ = fields.pop()
module, cls = self.clinic._module_and_class(fields)
if cls:
fail("Can't nest a module inside a class!")
Expand Down