Skip to content

gh-104050: Add more type annotations to Argument Clinic #104631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
May 21, 2023
Merged

gh-104050: Add more type annotations to Argument Clinic #104631

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36ae292
gh-104050: Add more type annotations to Argument Clinic
erlend-aasland May 18, 2023
4a6fdfe
Pull in main
erlend-aasland May 20, 2023
d4055ea
Pull in main
erlend-aasland May 21, 2023
1da5282
Fix return converter
erlend-aasland May 21, 2023
ccd1bb6
WIP
erlend-aasland May 21, 2023
3877c7b
str does the trick?
erlend-aasland May 21, 2023
e239ab5
str does the trick again?
erlend-aasland May 21, 2023
0ecd3a1
Partially revert Function.copy() annotation
erlend-aasland May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
str does the trick again?
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 21, 2023
commit e239ab5cf939aa68d2b880f820e9827505a6b7fb
4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2506,7 +2506,7 @@ def __init__(
*,
default = inspect.Parameter.empty,
function: Function,
converter: CConverter,
converter: "CConverter",
annotation = inspect.Parameter.empty,
docstring: str | None = None,
group: int = 0
Expand Down Expand Up @@ -2535,7 +2535,7 @@ def is_vararg(self) -> bool:
def is_optional(self) -> bool:
return not self.is_vararg() and (self.default is not unspecified)

def copy(self, **overrides) -> Parameter:
def copy(self, **overrides) -> "Parameter":
kwargs = {
'name': self.name, 'kind': self.kind, 'default':self.default,
'function': self.function, 'converter': self.converter, 'annotation': self.annotation,
Expand Down