Skip to content

gh-104050: Run mypy on clinic.py in CI #104421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 16 commits into from
May 15, 2023
Merged

gh-104050: Run mypy on clinic.py in CI #104421

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ca8532b
Slightly annotate cpp.py
erlend-aasland Apr 30, 2023
d2ec2ef
Slightly annotate clinic.py
erlend-aasland May 1, 2023
801af38
Address review
erlend-aasland May 1, 2023
00183ff
Add basic mypy workflow to CI
AlexWaygood May 12, 2023
4bdd409
Make the type check pass
AlexWaygood May 12, 2023
632843b
Tweak workflow file
AlexWaygood May 12, 2023
f7e7a25
improve workflow file
AlexWaygood May 12, 2023
510e08b
Add some more return annotations
AlexWaygood May 12, 2023
773c2ba
simpler glob
AlexWaygood May 12, 2023
6c7ecb9
Address various reviews!
AlexWaygood May 12, 2023
717ee47
more from Hugo
AlexWaygood May 12, 2023
62669d1
Fix ini syntax
AlexWaygood May 12, 2023
ddd0843
Unused import
AlexWaygood May 12, 2023
b7158db
Merge branch 'main' into clinic-mypy-check
AlexWaygood May 12, 2023
9fcd87f
Restore compatibility with Python 3.8
AlexWaygood May 13, 2023
010f0dd
Revert "Restore compatibility with Python 3.8"
AlexWaygood May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ini syntax
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 12, 2023
commit 62669d1ee421551c48715d859e73485d8c948b3f
3 changes: 2 additions & 1 deletion Tools/clinic/mypy.ini
View file
Open in desktop

@AlexWaygood AlexWaygood May 12, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually put my mypy config in a pyproject.toml file these days, but a mypy.ini file feels like it makes more "sense" unless we're planning on adding other linters/formatters to check clinic.py in the future

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[mypy]
python_version = 3.10 # make sure clinic can still be run on Python 3.10
# make sure clinic can still be run on Python 3.10
Comment thread
AlexWaygood marked this conversation as resolved.
Resolved
python_version = 3.10
pretty = True
enable_error_code = ignore-without-code
disallow_any_generics = True
Expand Down