Skip to content

gh-103193: cache calls to inspect._shadowed_dict in inspect.getattr_static #104267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 4 commits into from
May 7, 2023
Merged

gh-103193: cache calls to inspect._shadowed_dict in inspect.getattr_static #104267

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb580ba
gh-103193: cache calls to inspect._shadowed_dict
AlexWaygood May 7, 2023
c26587c
Use mro tuple as the cache key
AlexWaygood May 7, 2023
b3cc123
Add regression test for if a class has its mro mutated(!)
AlexWaygood May 7, 2023
2f4b42f
Update perf numbers in whatsnew
AlexWaygood May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update perf numbers in whatsnew
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 7, 2023
commit 2f4b42faaffdc0952ee69158160ccc87a78080a9
7 changes: 4 additions & 3 deletions Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,9 @@ inspect
(Contributed by Thomas Krennwallner in :issue:`35759`.)

* The performance of :func:`inspect.getattr_static` has been considerably
improved. Most calls to the function should be around 2x faster than they
were in Python 3.11. (Contributed by Alex Waygood in :gh:`103193`.)
improved. Most calls to the function should be at least 2x faster than they
were in Python 3.11, and some may be 6x faster or more. (Contributed by Alex
Waygood in :gh:`103193`.)

pathlib
-------
Expand Down Expand Up @@ -597,7 +598,7 @@ typing
:func:`runtime-checkable protocols <typing.runtime_checkable>` has changed
significantly. Most ``isinstance()`` checks against protocols with only a few
members should be at least 2x faster than in 3.11, and some may be 20x
faster or more. However, ``isinstance()`` checks against protocols with seven
faster or more. However, ``isinstance()`` checks against protocols with fourteen
or more members may be slower than in Python 3.11. (Contributed by Alex
Waygood in :gh:`74690` and :gh:`103193`.)

Expand Down