Skip to content

gh-103906: Remove immortal refcounting in compile/marshal.c #103922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 4 commits into from
Jun 5, 2023
Merged

gh-103906: Remove immortal refcounting in compile/marshal.c #103922

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cdd24d
gh-103906: Remove immortal refcounting in compile.c
corona10 Apr 27, 2023
6d0dd68
Remove refcounting for Py_None
corona10 Apr 27, 2023
57d9b5f
Update Python/compile.c
corona10 Apr 27, 2023
414eae5
Remove more cases
corona10 Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-103906: Remove immortal refcounting in compile.c
  • Loading branch information
@corona10
corona10 committed Apr 27, 2023
commit 8cdd24ddd7d07a1cc6dda42a202bb66b756c5f63
4 changes: 2 additions & 2 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,10 +892,10 @@ static PyObject*
merge_consts_recursive(PyObject *const_cache, PyObject *o)
{
assert(PyDict_CheckExact(const_cache));
// None and Ellipsis are singleton, and key is the singleton.
// None and Ellipsis are immortal object, and key is the singleton.
Comment thread
corona10 marked this conversation as resolved.
Outdated
// No need to merge object and key.
if (o == Py_None || o == Py_Ellipsis) {
return Py_NewRef(o);
return o;
}

PyObject *key = _PyCode_ConstantKey(o);
Expand Down