Skip to content

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers #103674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 11 commits into from
Apr 24, 2023
Merged

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers #103674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a2f842
socketserver: Add missing ForkingUnixStreamServer and ForkingUnixData…
jb2170 Apr 22, 2023
364eb77
Add self to Misc/ACKS
jb2170 Apr 22, 2023
849feb2
Add NEWS entry with blurb
jb2170 Apr 22, 2023
d634059
style nit: add a missing space.
gpshead Apr 23, 2023
a9a91ed
ReSTify the NEWS entry.
gpshead Apr 23, 2023
e32b567
remove an unnecessary word in NEWS
gpshead Apr 23, 2023
58073d4
Add authorship
arhadthedev Apr 24, 2023
5f61e05
Update Lib/test/test_socketserver.py to use ForkingUnix{Stream,Datagr…
jb2170 Apr 24, 2023
afb4520
Merge branch 'main' into gh-103673
jb2170 Apr 24, 2023
7d0ac34
Merge branch 'main' into gh-103673
gpshead Apr 24, 2023
ee13a90
Add a versionadded 3.12 tag.
gpshead Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
socketserver: Add missing ForkingUnixStreamServer and ForkingUnixData… 
…gramServer servers
  • Loading branch information
@jb2170
jb2170 committed Apr 22, 2023
commit 8a2f84271d6d9a7124a0efdb3b8f8eb9dee52f0a
4 changes: 4 additions & 0 deletions Doc/library/socketserver.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ server is the address family.
ForkingUDPServer
ThreadingTCPServer
ThreadingUDPServer
ForkingUnixStreamServer
ForkingUnixDatagramServer
ThreadingUnixStreamServer
ThreadingUnixDatagramServer

These classes are pre-defined using the mix-in classes.

Expand Down
7 changes: 7 additions & 0 deletions Lib/socketserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ class will essentially render the service "deaf" while one request is
__all__.extend(["UnixStreamServer","UnixDatagramServer",
"ThreadingUnixStreamServer",
"ThreadingUnixDatagramServer"])
if hasattr(os, "fork"):
__all__.extend(["ForkingUnixStreamServer","ForkingUnixDatagramServer"])
Comment thread
gpshead marked this conversation as resolved.
Outdated

# poll/select have the advantage of not requiring any extra file descriptor,
# contrarily to epoll/kqueue (also, they require a single syscall).
Expand Down Expand Up @@ -727,6 +729,11 @@ class ThreadingUnixStreamServer(ThreadingMixIn, UnixStreamServer): pass

class ThreadingUnixDatagramServer(ThreadingMixIn, UnixDatagramServer): pass

if hasattr(os, "fork"):
class ForkingUnixStreamServer(ForkingMixIn, UnixStreamServer): pass

class ForkingUnixDatagramServer(ForkingMixIn, UnixDatagramServer): pass

class BaseRequestHandler:

"""Base class for request handler classes.
Expand Down