Skip to content

bpo-35171: Fix test_TimeRE_recreation_timezone failure on some systems #10347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminp merged 1 commit into from
Nov 6, 2018
Merged

bpo-35171: Fix test_TimeRE_recreation_timezone failure on some systems #10347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-35171: Fix test_TimeRE_recreation_timezone failure on some systems 
The test depended on '/usr/share/zoneinfo/posixrules' or equivalent
because it set TZ without explicit DST transition rules. At least
on OpenSUSE Tumbleweed that file is linked to '/etc/localtime',
making the test fail with certain local timezones,
such as 'Europe/Moscow' which doesn't have DST transitions since 2011.
  • Loading branch information
Alexey Izbyshev
Alexey Izbyshev committed Nov 5, 2018
commit 8346116b6426256d04847dd88b138d24edac1743
2 changes: 1 addition & 1 deletion Lib/test/test_strptime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ def test_TimeRE_recreation_locale(self):
finally:
locale.setlocale(locale.LC_TIME, locale_info)

@support.run_with_tz('STD-1DST')
@support.run_with_tz('STD-1DST,M4.1.0,M10.1.0')
def test_TimeRE_recreation_timezone(self):
# The TimeRE instance should be recreated upon changing the timezone.
oldtzname = time.tzname
Expand Down