Skip to content

gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final #103173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood wants to merge 2 commits into from
Closed

gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final #103173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777f477
gh-103171: Document behaviour change in 3.11 for runtime-checkable pr…
AlexWaygood Apr 1, 2023
7acdd60
Add a test, too
AlexWaygood Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a test, too
  • Loading branch information
@AlexWaygood
AlexWaygood committed Apr 1, 2023
commit 7acdd6043e3cbc4a59edc52e6fdf6f332821ac78
16 changes: 16 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,6 +2597,22 @@ def meth(x): ...
with self.assertRaises(TypeError):
isinstance(C(), BadPG)

def test_protocols_isinstance_final(self):
@final
@runtime_checkable
class FinalHasX(Protocol):
x: int

class Eggs:
x = 42

@final
class Spam:
x = 42

self.assertNotIsInstance(Eggs(), FinalHasX)
self.assertIsInstance(Spam(), FinalHasX)

def test_protocols_isinstance_properties_and_descriptors(self):
class C:
@property
Expand Down