Skip to content

gh-101659: Clean Up the General Import Tests for Subinterpreters #103151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 3 commits into from
Mar 31, 2023
Merged

gh-101659: Clean Up the General Import Tests for Subinterpreters #103151

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88c099b
Don't test against sys (for now).
ericsnowcurrently Mar 31, 2023
e7ee839
Clean up SubinterpImportTests.
ericsnowcurrently Mar 31, 2023
9c8d480
Ensure we are testing against the right type of extension.
ericsnowcurrently Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't test against sys (for now).
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Mar 31, 2023
commit 88c099b03aaff34484e2f939029564d253cf2008
4 changes: 3 additions & 1 deletion Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,9 @@ def check_incompatible_isolated(self, name):
)

def test_builtin_compat(self):
module = 'sys'
# For now we avoid using sys or builtins
# since they still don't implement multi-phase init.
module = '_imp'
with self.subTest(f'{module}: not strict'):
self.check_compatible_shared(module, strict=False)
with self.subTest(f'{module}: strict, shared'):
Expand Down