Skip to content

gh-103092: Isolate _collections #103093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 22 commits into from
Apr 12, 2023
Merged

gh-103092: Isolate _collections #103093

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7965cb3
Establish global state
erlend-aasland Feb 1, 2023
3d7fd7c
Add module level helpers
erlend-aasland Feb 1, 2023
868619e
WIP
erlend-aasland Feb 1, 2023
cde3cd9
More WIP
erlend-aasland Feb 3, 2023
83ccb7f
Purge globals-to-fix
erlend-aasland Mar 28, 2023
a7b2b75
Pull in main
erlend-aasland Apr 5, 2023
e815144
Fix up ADD_TYPE
erlend-aasland Apr 6, 2023
05df1b3
Pull in main
erlend-aasland Apr 8, 2023
c9de410
fix return
kumaraditya303 Apr 9, 2023
a0af773
use _PyType_GetModuleState
kumaraditya303 Apr 9, 2023
3d60806
add parens
kumaraditya303 Apr 9, 2023
1b05b82
blurb
kumaraditya303 Apr 9, 2023
f91ce89
Merge branch 'main' of https://github.com/python/cpython into isolate…
kumaraditya303 Apr 9, 2023
0bce276
Pull in main
erlend-aasland Apr 9, 2023
45a26f3
Don't call PyDict_Type stuff directly from dealloc, traverse, and clear
erlend-aasland Apr 9, 2023
2e4e957
Revert unneeded change and cast in defdict_dealloc
erlend-aasland Apr 9, 2023
f4c937f
Fixup dequeiter_dealloc()
erlend-aasland Apr 9, 2023
d7afd96
Fix typenames
erlend-aasland Apr 10, 2023
e4aa153
Fix defdict_or
erlend-aasland Apr 10, 2023
0dcfcef
Explicitly import _deque_iterator
erlend-aasland Apr 10, 2023
0381b45
Fix deallocation (hopefully)
kumaraditya303 Apr 12, 2023
e7e8b1a
Merge branch 'main' into isolate-collections
AlexWaygood Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup dequeiter_dealloc()
  • Loading branch information
@erlend-aasland
erlend-aasland committed Apr 9, 2023
commit f4c937fee03bd367dd606d866da6722e3eaa1079
2 changes: 1 addition & 1 deletion Modules/_collectionsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,7 +1728,7 @@ dequeiter_dealloc(dequeiterobject *dio)
/* bpo-31095: UnTrack is needed before calling any callbacks */
PyTypeObject *tp = Py_TYPE(dio);
PyObject_GC_UnTrack(dio);
tp->tp_clear((PyObject *)dio);
(void)dequeiter_clear(dio);
PyObject_GC_Del(dio);
Py_DECREF(tp);
}
Expand Down