Repository navigation

GH-103082: Implementation of PEP 669: Low Impact Monitoring for CPython - #103083

Merged

markshannon merged 127 commits into

python:mainfrom

faster-cpython:pep-669

Apr 12, 2023

Commits on Nov 11, 2022
- Initial experimental implementation of PEP 669.
  markshannon
  committed
  e85d910
Commits on Nov 18, 2022
- First draft implementing small subset of PEP 669.
  markshannon
  committed
  6283ee8
Commits on Nov 28, 2022
- Support disabling and restarting.
  markshannon
  committed
  4edb7b7
Commits on Nov 30, 2022
- Support multiple tools per event.
  markshannon
  committed
  852c40b
Commits on Dec 2, 2022
- Tidy up of monitoring internals
  markshannon
  committed
  416b314
Commits on Dec 4, 2022
- Fix legacy tracing.
  markshannon
  committed
  7971979
Commits on Dec 8, 2022
- Implement support for multiple tools.
  markshannon
  committed
  9896902
Commits on Dec 22, 2022
- Get support for line tracing mostly working. Needs to wait for register VM.
  markshannon
  committed
  f432a66
Commits on Jan 13, 2023
- Merge branch 'main' into pep-669-incremental
  markshannon
  committed
  fb29b34
- Fix up INSTRUMENTED_OPCODES vector.
  markshannon
  committed
  15a1ccd
Commits on Jan 16, 2023
- Fix instrumented branches to call instrumentation with correct target.
  markshannon
  committed
  9abb339
Commits on Jan 17, 2023
- Merge main and assorted fixups to handle new instruction.
  markshannon
  committed
  3ba6a39
- Add PY_THROW event handling and fix up line table.
  markshannon
  committed
  aa09895
- LINE events working for sys.setrace.
  markshannon
  committed
  9e5d87d
Commits on Jan 18, 2023
- Add lots of internal debugging for instrumentation.
  markshannon
  committed
  e52cbe6
- Add more tests. Get those and some other passing.
  markshannon
  committed
  6c8be7e
Commits on Jan 19, 2023
- Fix LINE instrumentation and frame.set_lineno support (mostly)
  markshannon
  committed
  c9e1e21
Commits on Jan 20, 2023
- Refining line event generation.
  markshannon
  committed
  e52e8d3
- Get sys.settrace tests passing.
  markshannon
  committed
  f434ec7
- Monitor 'internal' StopIteration raises.
  markshannon
  committed
  b680084
- Check for NULLs.
  markshannon
  committed
  e6e7cf1
- Fix up a few tests
  markshannon
  committed
  5bbc83e
Commits on Jan 23, 2023
- Turn off debugging output by default.
  markshannon
  committed
  7fe9a43
Commits on Jan 26, 2023
- Remove debugging printfs
  markshannon
  committed
  8b9f996
- Avoid refleak.
  markshannon
  committed
  9b02640
- Record last traced line on frame object.
  markshannon
  committed
  2cadf32
Commits on Jan 30, 2023
- Get a couple more top-level tests passing.
  markshannon
  committed
  1f54d77
- Update magic number
  markshannon
  committed
  43a3f3e
- Remove debug print statement.
  markshannon
  committed
  3d436cf
- Raise SystemError if frame is missing.
  markshannon
  committed
  691bcf5
Commits on Jan 31, 2023
- Restore a few tests and better handle EXTENDED_ARG.
  markshannon
  committed
  f07be07
Commits on Feb 1, 2023
- Make sure instrumentation respects instruction boundaries.
  markshannon
  committed
  8b8f67e
- Fix handling of errors in jump instruments
  markshannon
  committed
  d0a2228
- Fix memory leaks.
  markshannon
  committed
  2a3a85e
- Instrument FOR_ITER.
  markshannon
  committed
  c3724ab
Commits on Feb 2, 2023
- Fix legacy profiling of calls.
  markshannon
  committed
  d64823c
Commits on Feb 3, 2023
- Fix up instrumented yield.
  markshannon
  committed
  284d0b1
Commits on Feb 8, 2023
- Merge branch 'main' into pep-669-incremental
  markshannon
  committed
  b9e1f3b
Commits on Feb 9, 2023
- Fix instrumentation of SEND and tidy up instrumented bytecode numbering.
  markshannon
  committed
  1440473
- Handle line numbers in exception handled event.
  markshannon
  committed
  825f42a
Commits on Feb 10, 2023
- Instrument END_FOR to mimic PEP 380 StopIteration and add more tests.
  markshannon
  committed
  ce5ddb3
Commits on Feb 13, 2023
- Merge branch 'main' into pep-669-incremental
  markshannon
  committed
  5740c47
Commits on Feb 14, 2023
- Add END_SEND for instrumentation.
  markshannon
  committed
  da83abe
- Correctly set StopIteration in INSTRUMENTED_END_FOR.
  markshannon
  committed
  cdb2bda
- Set last traced line when jumping in debugger.
  markshannon
  committed
  0148fa3
Commits on Feb 17, 2023
- Fix test_dis to account for END_SEND.
  markshannon
  committed
  c5fb4f4
- Add a few more tests.
  markshannon
  committed
  7fa431b
- delete commented out code
  markshannon
  committed
  25bbc61
- Fix last (known) inconsistency in sys.settrace behaviour
  markshannon
  committed
  5629a3e
Commits on Feb 20, 2023
- More clearly differentiate between instrumented events and non-instrumented events.
  markshannon
  committed
  477cc53
Commits on Feb 21, 2023
- Add support for sys.monitoring.MISSING
  markshannon
  committed
  23b5f5e
Commits on Feb 23, 2023
- Add support for local (per-code-object) event monitoring.
  markshannon
  committed
  dfc18c5
- Merge branch 'main' into pep-669
  markshannon
  committed
  566adbe
- Make sure that tracing/profiling thread counts are correct.
  markshannon
  committed
  cfb17ed
- Remove linearray field
  markshannon
  committed
  c535f76
- Rename some fields, shortening names.
  markshannon
  committed
  d579d2e
- Remove out of dat comments.
  markshannon
  committed
  0982e5e
Commits on Mar 22, 2023
- Remove instrumentation for JUMP_IF_[FALS|TRUE]_OR_POP
  markshannon
  committed
  0693423
- Merge branch 'main' into pep-669
  markshannon
  committed
  d6453e5
Commits on Mar 23, 2023
- Minor fixups from merge.
  markshannon
  committed
  0ee2aee
- Remove instrumentation for COMPARE_AND_BRANCH.
  markshannon
  committed
  acdca93
- Merge branch 'main' into pep-669
  markshannon
  committed
  f17ef14
- Group instrumented opcodes.
  markshannon
  committed
  e7f6c37
- Remove last references to DO_TRACING
  markshannon
  committed
  e44ebc5
- Merge branch 'main' into pep-669
  markshannon
  committed
  ece51e6
- Remove unused function.
  markshannon
  committed
  e88921e
- Streamline de-instrumentation a little.
  markshannon
  committed
  2d9f22c
- Use modern API for saving and restoring exception.
  markshannon
  committed
  b7579ac
Commits on Mar 24, 2023
- Refactor instrumentation calls to reduce duplication.
  markshannon
  committed
  5a089a6
- Fix refleaks
  markshannon
  committed
  d5fdec8
- Remove commented out code.
  markshannon
  committed
  c88741d
- Make sure that stacktop == -1 when stack_pointer is cached.
  markshannon
  committed
  b6744ca
- Minor cleanups.
  markshannon
  committed
  6c3473a
- Remove useless asserts.
  markshannon
  committed
  899aecd
- Make functions static
  markshannon
  committed
  80d2e2e
- Update Windows build files.
  markshannon
  committed
  94d35d8
- Make _PyLegacyEventHandler_Type immortal
  markshannon
  committed
  5aa0805
- Make arrays const.
  markshannon
  committed
  b39edd3
- Rename _PyFrame_GetStackPointer to _PyFrame_FetchStackPointer and make it responsible for setting stacktop to -1.
  markshannon
  committed
  c9c40cb
- Fixups from code review
  markshannon
  committed
  6611c72
- Improve debugging output and make a few things more robust.
  markshannon
  committed
  50d28f1
Commits on Mar 25, 2023
- Fix up frame.set_lineno().
  markshannon
  committed
  7165f52
- Make line instrumentation able to handle multiple inits.
  markshannon
  committed
  65c548e
- Add brief comments on instrumentation data structures.
  markshannon
  committed
  575f7d1
- Add symbol constant for min instrumented opcode.
  markshannon
  committed
  415741d
- Code cleanup from review.
  markshannon
  committed
  d70a1a4
- A bit more cleanup.
  markshannon
  committed
  d580de6
- Add a few more comments.
  markshannon
  committed
  2076d5f
- Remove unused code.
  markshannon
  committed
  7b32d79
- Fix leak of monitoring blocks.
  markshannon
  committed
  662c16c
- Merge branch 'main' into pep-669
  markshannon
  committed
  d0139e9
- Make function static.
  markshannon
  committed
  51a93e7
Commits on Mar 26, 2023
- Use symbolic constants in line computations.
  markshannon
  committed
  64bf37f
- Make data static.
  markshannon
  committed
  5faec77
- Add extra check.
  markshannon
  committed
  0be1562
- Make sure that instrumentation of line and instructions at the same time is supported.
  markshannon
  committed
  b32a075
Commits on Mar 31, 2023
- Remove incorrect assertion.
  markshannon
  committed
  85d6923
- Turn off instrumentation debugging.
  markshannon
  committed
  ebcc42f
- Fix a couple of errors.
  markshannon
  committed
  7cfbc7e
- Add minimal news entry.
  markshannon
  committed
  d366364
- Pacify the global object checker.
  markshannon
  committed
  fdb4860
Commits on Apr 3, 2023
- Minor fixups.
  markshannon
  committed
  aee722f
- Fix refleak when error in RETURN instrumentation.
  markshannon
  committed
  bba53b8
- Merge branch 'main' into pep-669
  markshannon
  committed
  718fbc8
- Fix another refleak in error handling in instrumented instruction.
  markshannon
  committed
  97ec1c5
- Remove debug code ready for final review.
  markshannon
  committed
  edc6709
- Fix another (and hopefully final) refleak when handling an error in an instrumented bytecode.
  markshannon
  committed
  e40a68f
Commits on Apr 4, 2023
- Comment and rename #defines to better reflect names in PEP.
  markshannon
  committed
  d9f8192
- Add various IDs as defined in the PEP.
  markshannon
  committed
  2d9a380
- Remove _PyThreadState_UpdateTracingState.
  markshannon
  committed
  29f41e7
- Formatting fixes, and check error codes.
  markshannon
  committed
  38b7f43
- Make sure tool API function names match PEP.
  markshannon
  committed
  9a40dad
- A bit more cleanup.
  markshannon
  committed
  a551d65
- Tidy up imports.
  markshannon
  committed
  4951306
- Use clinic return converters.
  markshannon
  committed
  44a031e
- Address code review.
  markshannon
  committed
  c2155b7
- Address further review comments.
  markshannon
  committed
  b218428
Commits on Apr 5, 2023
- Use byte offset, to conform to the convention used in other APIs taking code offsets.
  markshannon
  committed
  9c0429e
- Address code review.
  markshannon
  committed
  c6bf38e
- Merge branch 'main' into pep-669
  markshannon
  committed
  82fe16c
- Keep check-c-globals happy.
  markshannon
  committed
  43618a9
Commits on Apr 9, 2023
- Don't crash if locals events aren't set.
  markshannon
  committed
  821ae52
- Add NO_EVENTS.
  markshannon
  committed
  505a08d
- Flip order of LINE and INSTRUCTION events.
  markshannon
  committed
  f63da91
- Check tool is in use when setting events.
  markshannon
  committed
  c324344
Commits on Apr 12, 2023
- Reset last traced line number when setting frame.f_trace only if set to new value.
  markshannon
  committed
  168b34a
- Tidy up test case.
  markshannon
  committed
  f07a080

Commits

Commits on Nov 11, 2022

Commits on Nov 18, 2022

Commits on Nov 28, 2022

Commits on Nov 30, 2022

Commits on Dec 2, 2022

Commits on Dec 4, 2022

Commits on Dec 8, 2022

Commits on Dec 22, 2022

Commits on Jan 13, 2023

Commits on Jan 16, 2023

Commits on Jan 17, 2023

Commits on Jan 18, 2023

Commits on Jan 19, 2023

Commits on Jan 20, 2023

Commits on Jan 23, 2023

Commits on Jan 26, 2023

Commits on Jan 30, 2023

Commits on Jan 31, 2023

Commits on Feb 1, 2023

Commits on Feb 2, 2023

Commits on Feb 3, 2023

Commits on Feb 8, 2023

Commits on Feb 9, 2023

Commits on Feb 10, 2023

Commits on Feb 13, 2023

Commits on Feb 14, 2023

Commits on Feb 17, 2023

Commits on Feb 20, 2023

Commits on Feb 21, 2023

Commits on Feb 23, 2023

Commits on Mar 22, 2023

Commits on Mar 23, 2023

Commits on Mar 24, 2023

Commits on Mar 25, 2023

Commits on Mar 26, 2023

Commits on Mar 31, 2023

Commits on Apr 3, 2023

Commits on Apr 4, 2023